You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 17:38:49 UTC
[GitHub] [arrow-datafusion] sarahyurick opened a new pull request, #3235: Support "IS TRUE/FALSE" syntax (redo)
sarahyurick opened a new pull request, #3235:
URL: https://github.com/apache/arrow-datafusion/pull/3235
# Which issue does this PR close?
Closes #3159
# What changes are included in this PR?
Redo of #3189 with the `IsNotDistinctFrom` operator instead, from @alamb's suggestion. Includes SQL-level tests as well.
Since `IS TRUE` and `IS FALSE` should only work on boolean and null datatypes, we are waiting on #3222 so that we can add type validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3235: Support "IS TRUE/FALSE" syntax (redo)
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3235:
URL: https://github.com/apache/arrow-datafusion/pull/3235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3235: Support "IS TRUE/FALSE" syntax (redo)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3235:
URL: https://github.com/apache/arrow-datafusion/pull/3235#issuecomment-1225660495
Benchmark runs are scheduled for baseline = aa6a34b4d1110b1a3b19276885d1b9e81277ce34 and contender = c11f303bcec4f6b34e3e621bbb6763b62a38fe79. c11f303bcec4f6b34e3e621bbb6763b62a38fe79 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a64b58a15c164fc6b0717d0a4c2f2785...8f01477b41de4deab0a4d30732e16544/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/20724f1c4f9344d9b10b32edec9d4a9b...bd8d7a9cf6624bc98c75484fb9507bde/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a36760a743f5493ca6b8a2f0e1792a0c...072c8b7f8d914edab2c394a597944141/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/12d4bbd23ef0499bacefb5c3abe3a925...5179016365d848a18711d08fc1fd8185/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3235: Support "IS TRUE/FALSE" syntax (redo)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3235:
URL: https://github.com/apache/arrow-datafusion/pull/3235#issuecomment-1224538925
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3235](https://codecov.io/gh/apache/arrow-datafusion/pull/3235?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79759f1) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/74872a31969c01d976ecc36135082c8b8aeaf953?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74872a3) will **increase** coverage by `0.02%`.
> The diff coverage is `90.00%`.
```diff
@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
+ Coverage 85.81% 85.84% +0.02%
==========================================
Files 292 293 +1
Lines 53117 53206 +89
==========================================
+ Hits 45585 45675 +90
+ Misses 7532 7531 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `78.90% <50.00%> (+0.89%)` | :arrow_up: |
| [datafusion/optimizer/tests/integration-test.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvdGVzdHMvaW50ZWdyYXRpb24tdGVzdC5ycw==) | `84.00% <84.00%> (ø)` | |
| [datafusion/core/tests/sql/expr.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9leHByLnJz) | `99.85% <100.00%> (+<0.01%)` | :arrow_up: |
| [datafusion/sql/src/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3BsYW5uZXIucnM=) | `80.52% <100.00%> (+0.07%)` | :arrow_up: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `93.27% <0.00%> (+0.84%)` | :arrow_up: |
| [datafusion/expr/src/utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy91dGlscy5ycw==) | `91.10% <0.00%> (+1.07%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org