You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/22 02:36:31 UTC
[GitHub] [apisix-website] spacewander opened a new issue, #1047: [Docs]: Let's add a linter to detect 404 link
spacewander opened a new issue, #1047:
URL: https://github.com/apache/apisix-website/issues/1047
### Current State
**Description of the current state/issue**:
People keep reporting the broken links during the refactor of the documentation.
**Link to the page**:
**Screenshots (if relevant)**:
### Desired State
**Description of the change you are proposing**:
It would be greater if we can add a linter to detect the broken links.
### Would you like to fix this issue?
No. Please assign another contributor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] navendu-pottekkat commented on issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on issue #1047:
URL: https://github.com/apache/apisix-website/issues/1047#issuecomment-1108636219
@SkyeYoung Yes. That is correct. However, does the current link checker check for cases where links are on other repos?
Since all the files from all the repos are pulled in `apisix-website` during build, links referencing other repos should work for the link checker in this repository.
For docs changes in the other repos, we can't however check this as we do not build the website in those repos. Only static link checking will work and it will fail in the case where we refer documents in other repos.
Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1047:
URL: https://github.com/apache/apisix-website/issues/1047#issuecomment-1107679989
I think this issue can be closed since we already have a link checker, and the question of whether there is a problem with the link checker in operation should be discussed in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] spacewander commented on issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1047:
URL: https://github.com/apache/apisix-website/issues/1047#issuecomment-1105975593
It is suggested to add linter in the website to solve this problem:
https://github.com/apache/apisix/pull/6881#discussion_r853765224
CC @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] spacewander closed issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #1047: [Docs]: Let's add a linter to detect 404 link
URL: https://github.com/apache/apisix-website/issues/1047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1047:
URL: https://github.com/apache/apisix-website/issues/1047#issuecomment-1108707119
@navendu-pottekkat Hi, I created a new issue to discuss current problems of link checker. So, sorry, I moved the reply thereļ¼ you can check https://github.com/apache/apisix-website/issues/1055#issuecomment-1108703660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #1047: [Docs]: Let's add a linter to detect 404 link
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on issue #1047:
URL: https://github.com/apache/apisix-website/issues/1047#issuecomment-1105969912
In fact, we already have one https://github.com/apache/apisix-website/actions/workflows/link-check.yml.
But in website we can only ensure that there are no broken links in the blog pages. The documentation of other projects needs to be checked by each project itself. We shouldn't solve the problems of other repositories in the website repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org