[GitHub] [rocketmq] ni-ze commented on a change in pull request #4045: [ISSUE #4033] fix async deliver msg will resend forever when serivce not avliable

[GitBox <gi...@apache.org>]

ni-ze commented on a change in pull request #4045:
URL: https://github.com/apache/rocketmq/pull/4045#discussion_r838080681



##########
File path: store/src/main/java/org/apache/rocketmq/store/schedule/ScheduleMessageService.java
##########
@@ -555,7 +555,7 @@ public void run() {
                                 return;
                             }
                             log.warn("putResultProcess error, info={}", putResultProcess.toString());
-                            putResultProcess.onException();
+                            putResultProcess.doResend();

Review comment:
       if a exception occur in doResend which will also cause infinite resend， there is not chance to reach SKIP status.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org