[GitHub] traeak opened a new pull request #3367: astats increase file buffer size, fix compiler warnings

[GitBox <gi...@apache.org>]

traeak opened a new pull request #3367: astats increase file buffer size, fix compiler warnings
URL: https://github.com/apache/trafficcontrol/pull/3367
 
 
   ## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
   
   Looking for a reporting bug, determined that the astats buffer for scanning /proc/net/dev is too small, especially for a test host that is running docker with many virtual network interfaces.  Also cleaned up a (valid) compiler warning over a signed/vs unsigned check regarding snprintf.
   
   ## Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [x] Other *astats_over_http plugin*
   
   ## What is the best way to verify this PR? Please include manual steps or automated tests. 
   ### (If no tests are part of this PR, please provide explanation as to why no tests are included.)
   
   Compile and install onto ATS, run curl on localhost
   
   ```
   curl -Lv  "http://ats:8080/_astats?application=system&inf.name=<iface>"
   ```
   
   ensure *proc.net.dev* shows up in the *system:* section
   
   ## Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services