You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/19 05:32:26 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #3909: [webserver] Introduce mustache and make BE webserver more pretty
acelyc111 opened a new pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 closed pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#issuecomment-650913227
@imay @morningman could you please rereview this PR, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#discussion_r443125786
##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -685,6 +685,18 @@ build_cctz() {
make -j$PARALLEL && make install
}
+#mustache
+build_mustache() {
Review comment:
In `https://github.com/henryr/cpp-mustache/` it said:
`Easiest way is to drop mustache.{cc,h} in your project.`
so why not just introduce the 2 files? So that we don't need to update our compile env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 edited a comment on pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 edited a comment on pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#issuecomment-653860487
I‘ll split this pr to multiple prs, the first one: https://github.com/apache/incubator-doris/pull/4021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#discussion_r443453113
##########
File path: be/src/www/bootstrap/js/bootstrap.min.js
##########
@@ -0,0 +1,7 @@
+/*!
Review comment:
Added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#issuecomment-653860487
I‘ll split the pr to multiple prs, the 1st: https://github.com/apache/incubator-doris/pull/4021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#discussion_r443347226
##########
File path: be/src/www/doris.js
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I've moved all be's web files to /webroot/be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3909: [webserver] Make BE webserver more pretty
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3909:
URL: https://github.com/apache/incubator-doris/pull/3909#discussion_r443096598
##########
File path: be/src/www/bootstrap/js/bootstrap.min.js
##########
@@ -0,0 +1,7 @@
+/*!
Review comment:
If new thirdparty file is added, "LICENSE.txt" will be updated
##########
File path: be/src/www/doris.js
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Why not put all web to /webroot?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org