[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6869: Add segment size rule to Recommendation Engine

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #6869:
URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r625548188



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -169,6 +172,33 @@ private void regulateCardinalityForAll() {
     });
   }
 

Review comment:
       Let's delete regulateCardinalityForAll() method. Should no longer be used after all the cardinality related changes in this PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org