You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/23 08:53:12 UTC
[GitHub] [flink] AHeise opened a new pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
AHeise opened a new pull request #14994:
URL: https://github.com/apache/flink/pull/14994
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Sources used to store their registered readers into the snapshot. However, when downscaling, they have unmatched readers that violate a couple of invariants.
The solution is to not store registered readers - they are re-registered on restart anyways.
To keep it backward compatible, the best option is to always store an empty list of readers while writing the snapshot and discard any recovered readers from the snapshot.
## Verifying this change
A respective ITCase will be added as part of #13845 (FLINK-19801).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d176682b14e7d26d940597e86521507d276c4e28 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4f4152b9881a9349eae5c5549016f8e9d87da9b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647)
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784015028
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f6d78130bb8061b2a19ebc8a83c81e16cd18aa0b (Tue Feb 23 08:55:17 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-786136731
Failed due to unrelated FLINK-17510 ... merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4f4152b9881a9349eae5c5549016f8e9d87da9b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #14994:
URL: https://github.com/apache/flink/pull/14994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d176682b14e7d26d940597e86521507d276c4e28 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d176682b14e7d26d940597e86521507d276c4e28 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636)
* d4f4152b9881a9349eae5c5549016f8e9d87da9b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
* 625c41212d0e89baad76b743e2850a8e6a0e502a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
}, {
"hash" : "67bcd38b44988f459166dd273fe05b99c743949f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778",
"triggerID" : "67bcd38b44988f459166dd273fe05b99c743949f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 625c41212d0e89baad76b743e2850a8e6a0e502a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770)
* 67bcd38b44988f459166dd273fe05b99c743949f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
* 625c41212d0e89baad76b743e2850a8e6a0e502a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784423794
> Shouldn't we have an ITCase of rescaling and FLIP-27?
Yes, we should. It would very much look like UnalignedCheckpointITCase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784017351
+1
Thanks for fixing this so quickly!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d176682b14e7d26d940597e86521507d276c4e28 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636)
* d4f4152b9881a9349eae5c5549016f8e9d87da9b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d176682b14e7d26d940597e86521507d276c4e28 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636)
* d4f4152b9881a9349eae5c5549016f8e9d87da9b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
}, {
"hash" : "67bcd38b44988f459166dd273fe05b99c743949f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778",
"triggerID" : "67bcd38b44988f459166dd273fe05b99c743949f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bcd38b44988f459166dd273fe05b99c743949f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
}, {
"hash" : "67bcd38b44988f459166dd273fe05b99c743949f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778",
"triggerID" : "67bcd38b44988f459166dd273fe05b99c743949f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
* 625c41212d0e89baad76b743e2850a8e6a0e502a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770)
* 67bcd38b44988f459166dd273fe05b99c743949f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13778)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4f4152b9881a9349eae5c5549016f8e9d87da9b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647)
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-786108424
Added it and waiting for AZP to turn green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14994: [FLINK-21452][connector/common] Stop snapshotting registered readers in source coordinator.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14994:
URL: https://github.com/apache/flink/pull/14994#issuecomment-784019705
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d176682b14e7d26d940597e86521507d276c4e28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13636",
"triggerID" : "d176682b14e7d26d940597e86521507d276c4e28",
"triggerType" : "PUSH"
}, {
"hash" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13647",
"triggerID" : "d4f4152b9881a9349eae5c5549016f8e9d87da9b",
"triggerType" : "PUSH"
}, {
"hash" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747",
"triggerID" : "82266e5cbe7a60169f070e232ee10ee57a1d9bd5",
"triggerType" : "PUSH"
}, {
"hash" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770",
"triggerID" : "625c41212d0e89baad76b743e2850a8e6a0e502a",
"triggerType" : "PUSH"
}, {
"hash" : "67bcd38b44988f459166dd273fe05b99c743949f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67bcd38b44988f459166dd273fe05b99c743949f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82266e5cbe7a60169f070e232ee10ee57a1d9bd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13747)
* 625c41212d0e89baad76b743e2850a8e6a0e502a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13770)
* 67bcd38b44988f459166dd273fe05b99c743949f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org