[jira] [Commented] (LENS-1346) License mention missing for AppDispatcher.js

["Raju Bairishetti (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LENS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650364#comment-15650364 ] 

Raju Bairishetti commented on LENS-1346:
----------------------------------------

Minor comment:  Can we mention  in LICENSE file as well  AppDispatcher.js file is under BSD LICENSE? Otherwise seems it will be treated as MIT license.

{noformat}
The following files are under MIT License

For lens-server/src/main/webapp/static/css/codemirror.min.css
lens-server/src/main/webapp/static/js/libs/codemirror.min.js
lens-server/src/main/webapp/static/js/libs/sql.js
...
...


For lens-ui/app/dispatcher/AppDispatcher.js
...
{noformat}

> License mention missing for AppDispatcher.js
> --------------------------------------------
>
>                 Key: LENS-1346
>                 URL: https://issues.apache.org/jira/browse/LENS-1346
>             Project: Apache Lens
>          Issue Type: Bug
>          Components: docs
>    Affects Versions: 2.5
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 2.7
>
>         Attachments: LENS-1346.patch
>
>
> Found an issue with one of the files : ./lens-ui/app/dispatcher/AppDispatcher.js
> The file is having copyright from Facebook and text says the license is BSD style which is in root directory of the source. But I don't see any corresponding license in root directory of the source. Seems the file is added in 2.5 release itself, but we need to put its corresponding license to top level LICENSE file. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)