[impala] 02/02: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

stakiar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 8e7fd6fe7ed79ba18a864c69753e2a5812f50034
Author: Sahil Takiar <ta...@gmail.com>
AuthorDate: Wed Jan 15 13:14:06 2020 -0800

    IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
    
    Modifies the ClusterMembershipMgr so that it prints a log statement
    everytime a node is removed from the blacklist. The log statement
    includes the reason the node was removed from the blacklist as well.
    
    Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
    Reviewed-on: http://gerrit.cloudera.org:8080/15110
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/scheduling/cluster-membership-mgr.cc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/be/src/scheduling/cluster-membership-mgr.cc b/be/src/scheduling/cluster-membership-mgr.cc
index e5d6f66..2364f24 100644
--- a/be/src/scheduling/cluster-membership-mgr.cc
+++ b/be/src/scheduling/cluster-membership-mgr.cc
@@ -193,6 +193,9 @@ void ClusterMembershipMgr::UpdateMembership(
         const TBackendDescriptor& be_desc = (*new_backend_map)[item.key];
         bool blacklisted = new_blacklist->FindAndRemove(be_desc)
             == ExecutorBlacklist::State::BLACKLISTED;
+        if (blacklisted) {
+          VLOG(1) << "Removing backend " << item.key << " from blacklist (deleted)";
+        }
         // If the backend was quiescing or was previously blacklisted, it will already
         // have been removed from 'executor_groups'.
         if (be_desc.is_executor && !be_desc.is_quiescing && !blacklisted) {
@@ -252,6 +255,9 @@ void ClusterMembershipMgr::UpdateMembership(
       TBackendDescriptor& existing = it->second;
       bool blacklisted =
           new_blacklist->FindAndRemove(be_desc) == ExecutorBlacklist::State::BLACKLISTED;
+      if (blacklisted) {
+        VLOG(1) << "Removing backend " << item.key << " from blacklist (updated)";
+      }
       if (be_desc.is_quiescing && !existing.is_quiescing && existing.is_executor
           && !blacklisted) {
         // Executor needs to be removed from its groups