You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2015/07/04 14:08:35 UTC
[2/5] directory-kerby git commit: Checkstyle: fix
LocalFinalVariableName, FinalClass, MemberName check
Checkstyle: fix LocalFinalVariableName, FinalClass, MemberName check
Project: http://git-wip-us.apache.org/repos/asf/directory-kerby/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-kerby/commit/60d4f51a
Tree: http://git-wip-us.apache.org/repos/asf/directory-kerby/tree/60d4f51a
Diff: http://git-wip-us.apache.org/repos/asf/directory-kerby/diff/60d4f51a
Branch: refs/heads/master
Commit: 60d4f51a5cbc8d4ef707a595192095bd1876a52c
Parents: e36fa26
Author: Stefan Seelmann <ma...@stefan-seelmann.de>
Authored: Sat Jul 4 13:44:29 2015 +0200
Committer: Stefan Seelmann <ma...@stefan-seelmann.de>
Committed: Sat Jul 4 14:06:04 2015 +0200
----------------------------------------------------------------------
.../org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java | 8 ++++----
.../kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java | 2 +-
.../apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java | 2 +-
.../org/apache/kerby/kerberos/provider/token/TokenTest.java | 8 ++++----
.../src/test/java/org/apache/kerby/config/IniConfigTest.java | 4 ++--
5 files changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/60d4f51a/kerby-kdc-test/src/test/java/org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java
----------------------------------------------------------------------
diff --git a/kerby-kdc-test/src/test/java/org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java b/kerby-kdc-test/src/test/java/org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java
index a326637..31bf0f1 100644
--- a/kerby-kdc-test/src/test/java/org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java
+++ b/kerby-kdc-test/src/test/java/org/apache/kerby/kerberos/kdc/WithTokenKdcTestBase.java
@@ -91,14 +91,14 @@ public class WithTokenKdcTestBase extends KdcTestBase {
authToken.setAudiences(aud);
// Set expiration in 60 minutes
- final Date NOW = new Date(new Date().getTime() / 1000 * 1000);
- Date exp = new Date(NOW.getTime() + 1000 * 60 * 60);
+ final Date now = new Date(new Date().getTime() / 1000 * 1000);
+ Date exp = new Date(now.getTime() + 1000 * 60 * 60);
authToken.setExpirationTime(exp);
- Date nbf = NOW;
+ Date nbf = now;
authToken.setNotBeforeTime(nbf);
- Date iat = NOW;
+ Date iat = now;
authToken.setIssueTime(iat);
krbToken = new KrbToken(authToken, TokenFormat.JWT);
return krbToken;
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/60d4f51a/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java b/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java
index a909170..bba6ebe 100644
--- a/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java
+++ b/kerby-kerb/kerb-common/src/main/java/org/apache/kerby/kerberos/kerb/preauth/pkinit/IdentityOpts.java
@@ -26,7 +26,7 @@ public class IdentityOpts {
// From MIT Krb5 _pkinit_identity_opts
public String identity;
- public List<String> AltIdentities = new ArrayList<String>(1);
+ public List<String> altIdentities = new ArrayList<String>(1);
public List<String> anchors = new ArrayList<String>(4);
public List<String> intermediates = new ArrayList<String>(2);
public List<String> crls = new ArrayList<String>(2);
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/60d4f51a/kerby-kerb/kerb-crypto/src/test/java/org/apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-crypto/src/test/java/org/apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java b/kerby-kerb/kerb-crypto/src/test/java/org/apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java
index f117fcd..af250b2 100644
--- a/kerby-kerb/kerb-crypto/src/test/java/org/apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java
+++ b/kerby-kerb/kerb-crypto/src/test/java/org/apache/kerby/kerberos/kerb/crypto/DesKeyMakerTest.java
@@ -13,7 +13,7 @@ public class DesKeyMakerTest {
/**
* The class used to store the test values
*/
- private static class TestCase {
+ private static final class TestCase {
String salt;
String passwd;
String passwdSaltBytes;
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/60d4f51a/kerby-provider/token-provider/src/test/java/org/apache/kerby/kerberos/provider/token/TokenTest.java
----------------------------------------------------------------------
diff --git a/kerby-provider/token-provider/src/test/java/org/apache/kerby/kerberos/provider/token/TokenTest.java b/kerby-provider/token-provider/src/test/java/org/apache/kerby/kerberos/provider/token/TokenTest.java
index f2b6000..d3fa8b2 100644
--- a/kerby-provider/token-provider/src/test/java/org/apache/kerby/kerberos/provider/token/TokenTest.java
+++ b/kerby-provider/token-provider/src/test/java/org/apache/kerby/kerberos/provider/token/TokenTest.java
@@ -65,14 +65,14 @@ public class TokenTest {
authToken.setAudiences(auds);
// Set expiration in 60 minutes
- final Date NOW = new Date(new Date().getTime() / 1000 * 1000);
- Date exp = new Date(NOW.getTime() + 1000 * 60 * 60);
+ final Date now = new Date(new Date().getTime() / 1000 * 1000);
+ Date exp = new Date(now.getTime() + 1000 * 60 * 60);
authToken.setExpirationTime(exp);
- Date nbf = NOW;
+ Date nbf = now;
authToken.setNotBeforeTime(nbf);
- Date iat = NOW;
+ Date iat = now;
authToken.setIssueTime(iat);
}
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/60d4f51a/lib/kerby-config/src/test/java/org/apache/kerby/config/IniConfigTest.java
----------------------------------------------------------------------
diff --git a/lib/kerby-config/src/test/java/org/apache/kerby/config/IniConfigTest.java b/lib/kerby-config/src/test/java/org/apache/kerby/config/IniConfigTest.java
index 75d7fb6..7b670df 100644
--- a/lib/kerby-config/src/test/java/org/apache/kerby/config/IniConfigTest.java
+++ b/lib/kerby-config/src/test/java/org/apache/kerby/config/IniConfigTest.java
@@ -32,8 +32,8 @@ import static org.assertj.core.api.Assertions.assertThat;
public class IniConfigTest {
- private final File TEST_DIR = new File(System.getProperty("test.dir","target"));
- private final File TEST_FILE = new File(TEST_DIR, "test-ini-config");
+ private static final File TEST_DIR = new File(System.getProperty("test.dir","target"));
+ private static final File TEST_FILE = new File(TEST_DIR, "test-ini-config");
@Before
public void setUp() throws IOException {