You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/22 10:24:21 UTC
[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.
mosche commented on a change in pull request #16077:
URL: https://github.com/apache/beam/pull/16077#discussion_r773775334
##########
File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java
##########
@@ -252,6 +371,16 @@ public static Read read() {
.build();
}
+ public static <T> Write<T> write() {
+ return new AutoValue_KinesisIO_Write.Builder<T>()
+ .batchMaxRecords(MAX_RECORDS_PER_REQUEST)
+ .batchMaxBytes((int) (MAX_BYTES_PER_REQUEST * 0.9)) // allow some error margin
+ .concurrentRequests(Write.DEFAULT_CONCURRENCY)
+ .aggregatedRecords(false)
Review comment:
Yes 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org