You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2015/07/25 10:37:04 UTC
[jira] [Commented] (HAMA-967) Remove a meaningless checking
condition.
[ https://issues.apache.org/jira/browse/HAMA-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641465#comment-14641465 ]
Edward J. Yoon commented on HAMA-967:
-------------------------------------
+1
> Remove a meaningless checking condition.
> ----------------------------------------
>
> Key: HAMA-967
> URL: https://issues.apache.org/jira/browse/HAMA-967
> Project: Hama
> Issue Type: Bug
> Components: bsp core
> Affects Versions: 0.7.0
> Reporter: JongYoon Lim
> Priority: Trivial
> Labels: cleanup
> Fix For: 0.7.1
>
> Attachments: HAMA-967.patch
>
>
> *split()* of *String* in *RPC* and *AsyncRPC* returns the array of strings. So checking *null* condition is meaningless.
> {code:java}
> String[] names = className.split("\\.", -1);
> if (names == null || names.length == 0) {
> return className;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)