[jira] [Commented] (YARN-1327) Fix nodemgr native compilation problems on FreeBSD9

["Dmitry Sivachenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112172#comment-14112172 ] 

Dmitry Sivachenko commented on YARN-1327:
-----------------------------------------

I am running Hadoop-2.4.1 on FreeBSD for some time now with this patch applied and noticed no issues with it.

> Fix nodemgr native compilation problems on FreeBSD9
> ---------------------------------------------------
>
>                 Key: YARN-1327
>                 URL: https://issues.apache.org/jira/browse/YARN-1327
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0
>            Reporter: Radim Kolar
>            Assignee: Radim Kolar
>             Fix For: 3.0.0, 2.6.0
>
>         Attachments: nodemgr-portability.txt
>
>
> There are several portability problems preventing from compiling native component on freebsd.
> 1. libgen.h is not included. correct function prototype is there but linux glibc has workaround to define it for user if libgen.h is not directly included. Include this file directly.
> 2. query max size of login name using sysconf. it follows same code style like rest of code using sysconf too.
> 3. cgroups are linux only feature, make conditional compile and return error if mount_cgroup is attempted on non linux OS
> 4. do not use posix function setpgrp() since it clashes with same function from BSD 4.2, use equivalent function. After inspecting glibc sources its just shortcut to setpgid(0,0)
> These changes makes it compile on both linux and freebsd.



--
This message was sent by Atlassian JIRA
(v6.2#6252)