You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/12 11:02:50 UTC

[GitHub] [airflow] ashb commented on a change in pull request #9243: [AIP-34] Rewrite SubDagOperator

ashb commented on a change in pull request #9243:
URL: https://github.com/apache/airflow/pull/9243#discussion_r439353408



##########
File path: airflow/models/dagbag.py
##########
@@ -314,34 +314,46 @@ def bag_dag(self, dag, parent_dag, root_dag):
         Throws AirflowDagCycleException if a cycle is detected in this dag or its subdags
         """
 
-        test_cycle(dag)  # throws if a task cycle is found

Review comment:
       Fairly sure this needs to stay :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org