You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "robberphex (via GitHub)" <gi...@apache.org> on 2023/02/12 16:30:12 UTC
[GitHub] [dubbo-rust] robberphex opened a new pull request, #109: Fix generated file duplication
robberphex opened a new pull request, #109:
URL: https://github.com/apache/dubbo-rust/pull/109
For dir `examples/echo`, there are `examples/echo/src/protos/hello_echo.rs` and `examples/echo/src/echo/grpc.examples.echo.rs`, which is duplicated.
Let's clarify those:
* `src/echo/` is source dir.
* `src/generated/` is generated source dir.
* `proto/` is `*.proto` dir.
*Why commit generated file(`examples/echo/src/generated/grpc.examples.echo.rs`) to the repo?*
It's helpful for code navigation, so keep it (temporarily).
*Why modified generated file?*
To pass rustfmt and license check, keep those edit, and I will fix those check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-rust] onewe commented on pull request #109: Fix generated file duplication
Posted by "onewe (via GitHub)" <gi...@apache.org>.
onewe commented on PR #109:
URL: https://github.com/apache/dubbo-rust/pull/109#issuecomment-1427411674
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-rust] AlbumenJ merged pull request #109: Fix generated file duplication
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #109:
URL: https://github.com/apache/dubbo-rust/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org