You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Martijn Visser <ma...@apache.org> on 2022/12/02 13:04:39 UTC
[VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Hi everyone,
Please review and vote on the release candidate #1 for the
flink-connector-hbase version v3.0.0, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
Note: This is the first externalized version of the HBase connector.
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.0.0-rc1 [5],
* website pull request listing the new release [6].
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Martijn
https://twitter.com/MartijnVisser82
https://github.com/MartijnVisser
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1555/
[5] https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
[6] https://github.com/apache/flink-web/pull/591
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Danny Cranmer <da...@apache.org>.
Hey Martijn,
+1 (binding)
- Verified signatures and hashes
- Contents of Maven repo look good
- No binaries in the source archive
- Tag exists in github
- Built source/tests pass
- Reviewed web PR
Thanks,
Danny
On Fri, Dec 2, 2022 at 1:05 PM Martijn Visser <ma...@apache.org>
wrote:
> Hi everyone,
> Please review and vote on the release candidate #1 for the
> flink-connector-hbase version v3.0.0, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> Note: This is the first externalized version of the HBase connector.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.0.0-rc1 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Martijn
>
> https://twitter.com/MartijnVisser82
> https://github.com/MartijnVisser
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> [2]
>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1555/
> [5]
> https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
> [6] https://github.com/apache/flink-web/pull/591
>
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Ferenc Csaky <fe...@pm.me.INVALID>.
Hi!
According to the last comment on the e2e test PR [1], it would be okay to release the connector in its current format and deliver a new/rewritten test later. Every other issue should be resolved.
[1] https://github.com/apache/flink-connector-hbase/pull/5
------- Original Message -------
On Friday, December 9th, 2022 at 08:13, Martijn Visser <ma...@apache.org> wrote:
>
>
> Thanks all for the check. This RC is cancelled and I'll create a new one
> when the fixes are done.
>
> On Thu, Dec 8, 2022 at 1:22 PM Ferenc Csaky ferenc.csaky@pm.me.invalid
>
> wrote:
>
> > Heck, thank you Chesnay for catching this. I spent some time on removing
> > the 1.4 hbase-client from flink-connector-hbase-2.2, cause excluding it
> > from flink-connector-hbase-base seemed not working. I missed removing that
> > exclusion from the 2.2 sql connector pom. Opened a PR [1] with the fix.
> >
> > [1] https://github.com/apache/flink-connector-hbase/pull/4
> >
> > ------- Original Message -------
> > On Thursday, December 8th, 2022 at 11:15, Chesnay Schepler <
> > chesnay@apache.org> wrote:
> >
> > > -1
> > >
> > > The packaging of the sql-connector-connector-hbase-2.2 module has
> > > changed significantly, no longer bundling hbase-client (it now only
> > > bundles Flink classes).
> > >
> > > On 05/12/2022 13:24, Ferenc Csaky wrote:
> > >
> > > > Hi Martijn,
> > > >
> > > > +1 (non-binding)
> > > >
> > > > - Verified hashes/signatures
> > > > - Maven repo content LGTM
> > > > - No binaries in the source archive
> > > > - Built source/tests pass
> > > > - Tag exists in GH
> > > > - Reviewed web PR
> > > >
> > > > Thanks,
> > > > F
> > > >
> > > > ------- Original Message -------
> > > > On Friday, December 2nd, 2022 at 14:04, Martijn Visser
> > > > martijnvisser@apache.org wrote:
> > > >
> > > > > Hi everyone,
> > > > > Please review and vote on the release candidate #1 for the
> > > > > flink-connector-hbase version v3.0.0, as follows:
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > > >
> > > > > Note: This is the first externalized version of the HBase connector.
> > > > >
> > > > > The complete staging area is available for your review, which
> > > > > includes:
> > > > > * JIRA release notes [1],
> > > > > * the official Apache source release to be deployed to
> > > > > dist.apache.org [2],
> > > > > which are signed with the key with fingerprint
> > > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > > * source code tag v3.0.0-rc1 [5],
> > > > > * website pull request listing the new release [6].
> > > > >
> > > > > The vote will be open for at least 72 hours. It is adopted by
> > > > > majority
> > > > > approval, with at least 3 PMC affirmative votes.
> > > > >
> > > > > Thanks,
> > > > > Martijn
> > > > >
> > > > > https://twitter.com/MartijnVisser82
> > > > > https://github.com/MartijnVisser
> > > > >
> > > > > [1]
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> >
> > > > > [2]
> >
> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
> >
> > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > [4]
> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1555/
> > > > > [5]
> > > > > https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
> > > > > [6] https://github.com/apache/flink-web/pull/591
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Martijn Visser <ma...@apache.org>.
Thanks all for the check. This RC is cancelled and I'll create a new one
when the fixes are done.
On Thu, Dec 8, 2022 at 1:22 PM Ferenc Csaky <fe...@pm.me.invalid>
wrote:
> Heck, thank you Chesnay for catching this. I spent some time on removing
> the 1.4 hbase-client from flink-connector-hbase-2.2, cause excluding it
> from flink-connector-hbase-base seemed not working. I missed removing that
> exclusion from the 2.2 sql connector pom. Opened a PR [1] with the fix.
>
> [1] https://github.com/apache/flink-connector-hbase/pull/4
>
>
>
> ------- Original Message -------
> On Thursday, December 8th, 2022 at 11:15, Chesnay Schepler <
> chesnay@apache.org> wrote:
>
>
> >
> >
> > -1
> >
> > The packaging of the sql-connector-connector-hbase-2.2 module has
> > changed significantly, no longer bundling hbase-client (it now only
> > bundles Flink classes).
> >
> > On 05/12/2022 13:24, Ferenc Csaky wrote:
> >
> > > Hi Martijn,
> > >
> > > +1 (non-binding)
> > >
> > > - Verified hashes/signatures
> > > - Maven repo content LGTM
> > > - No binaries in the source archive
> > > - Built source/tests pass
> > > - Tag exists in GH
> > > - Reviewed web PR
> > >
> > > Thanks,
> > > F
> > >
> > > ------- Original Message -------
> > > On Friday, December 2nd, 2022 at 14:04, Martijn Visser
> martijnvisser@apache.org wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #1 for the
> > > > flink-connector-hbase version v3.0.0, as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > Note: This is the first externalized version of the HBase connector.
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org [2],
> > > > which are signed with the key with fingerprint
> > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag v3.0.0-rc1 [5],
> > > > * website pull request listing the new release [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Martijn
> > > >
> > > > https://twitter.com/MartijnVisser82
> > > > https://github.com/MartijnVisser
> > > >
> > > > [1]
> > > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> > > > [2]
> > > >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1555/
> > > > [5]
> https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
> > > > [6] https://github.com/apache/flink-web/pull/591
> >
> >
>
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Ferenc Csaky <fe...@pm.me.INVALID>.
Heck, thank you Chesnay for catching this. I spent some time on removing the 1.4 hbase-client from flink-connector-hbase-2.2, cause excluding it from flink-connector-hbase-base seemed not working. I missed removing that exclusion from the 2.2 sql connector pom. Opened a PR [1] with the fix.
[1] https://github.com/apache/flink-connector-hbase/pull/4
------- Original Message -------
On Thursday, December 8th, 2022 at 11:15, Chesnay Schepler <ch...@apache.org> wrote:
>
>
> -1
>
> The packaging of the sql-connector-connector-hbase-2.2 module has
> changed significantly, no longer bundling hbase-client (it now only
> bundles Flink classes).
>
> On 05/12/2022 13:24, Ferenc Csaky wrote:
>
> > Hi Martijn,
> >
> > +1 (non-binding)
> >
> > - Verified hashes/signatures
> > - Maven repo content LGTM
> > - No binaries in the source archive
> > - Built source/tests pass
> > - Tag exists in GH
> > - Reviewed web PR
> >
> > Thanks,
> > F
> >
> > ------- Original Message -------
> > On Friday, December 2nd, 2022 at 14:04, Martijn Visser martijnvisser@apache.org wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #1 for the
> > > flink-connector-hbase version v3.0.0, as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > Note: This is the first externalized version of the HBase connector.
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org [2],
> > > which are signed with the key with fingerprint
> > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag v3.0.0-rc1 [5],
> > > * website pull request listing the new release [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Martijn
> > >
> > > https://twitter.com/MartijnVisser82
> > > https://github.com/MartijnVisser
> > >
> > > [1]
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> > > [2]
> > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4] https://repository.apache.org/content/repositories/orgapacheflink-1555/
> > > [5] https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
> > > [6] https://github.com/apache/flink-web/pull/591
>
>
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Chesnay Schepler <ch...@apache.org>.
-1
The packaging of the sql-connector-connector-hbase-2.2 module has
changed significantly, no longer bundling hbase-client (it now only
bundles Flink classes).
On 05/12/2022 13:24, Ferenc Csaky wrote:
> Hi Martijn,
>
> +1 (non-binding)
>
> - Verified hashes/signatures
> - Maven repo content LGTM
> - No binaries in the source archive
> - Built source/tests pass
> - Tag exists in GH
> - Reviewed web PR
>
> Thanks,
> F
>
>
> ------- Original Message -------
> On Friday, December 2nd, 2022 at 14:04, Martijn Visser <ma...@apache.org> wrote:
>
>
>>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the
>> flink-connector-hbase version v3.0.0, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> Note: This is the first externalized version of the HBase connector.
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org [2],
>> which are signed with the key with fingerprint
>> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v3.0.0-rc1 [5],
>> * website pull request listing the new release [6].
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Martijn
>>
>> https://twitter.com/MartijnVisser82
>> https://github.com/MartijnVisser
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
>> [2]
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1555/
>> [5] https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
>> [6] https://github.com/apache/flink-web/pull/591
Re: [VOTE] Release flink-connector-hbase v3.0.0, release candidate #1
Posted by Ferenc Csaky <fe...@pm.me.INVALID>.
Hi Martijn,
+1 (non-binding)
- Verified hashes/signatures
- Maven repo content LGTM
- No binaries in the source archive
- Built source/tests pass
- Tag exists in GH
- Reviewed web PR
Thanks,
F
------- Original Message -------
On Friday, December 2nd, 2022 at 14:04, Martijn Visser <ma...@apache.org> wrote:
>
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the
> flink-connector-hbase version v3.0.0, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> Note: This is the first externalized version of the HBase connector.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org [2],
> which are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.0.0-rc1 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Martijn
>
> https://twitter.com/MartijnVisser82
> https://github.com/MartijnVisser
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1555/
> [5] https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc1
> [6] https://github.com/apache/flink-web/pull/591