You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/07 21:14:28 UTC

[GitHub] cloudstack pull request: Fix 2 findbugs high priority warnings

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/363

    Fix 2 findbugs high priority warnings

    VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
    com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
    
    VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
    com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #363
    
----
commit 7873080bb822627868a36ba5b50ef6033af2f21b
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-07T09:44:28Z

    Fix 2 findbugs high priority warnings
    
    VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
    com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
    
    VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
    com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs high priority warnings

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/363#issuecomment-109890318
  
    asfbot issue is wioth git access. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs high priority warnings

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---