You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by 6harat <bh...@gmail.com> on 2023/06/18 10:04:21 UTC
[PR Review] Support for declaring WorkerHook in Flux topology definitions
Hey,
I submitted a PR for review yesterday and am looking for some help from
existing contributors regarding the below:
1. new JIRA ticket for the feature (and if someone can also approve my JIRA
account creation request if they are one of the approvers)
2. trigger the github workflow: https://github.com/apache/storm/pull/3546
(I already ran the test locally on my machine)
3. provide PR review comments
(attached the related mail from users mailing list)
Regards
6harat
Re: [PR Review] Support for declaring WorkerHook in Flux topology definitions
Posted by 6harat <bh...@gmail.com>.
Hey,
Bumping up this thread as I am still awaiting review comments on the
aforementioned PR: https://github.com/apache/storm/pull/3546
Let me know if anything else is required from my end.
On Tue, Jun 20, 2023 at 9:14 PM 6harat <bh...@gmail.com>
wrote:
> Hey,
>
> Just an update on the Apache JIRA account. I was able to get the access
> with help from users@infra.apache.org. Requesting existing maintainers to
> please add me to the relevant user group for being able to get the JIRA
> assigned to myself going forward. (I have create ticket and comment
> permission only)
>
> Also, thanks a lot @bipin for approving the github workflow. (It would be
> great if I could please get the access as well. I want to trigger it for
> other PRs too)
> Since the workflow tests have passed and relevant test cases were also
> added, could someone please help review the PR.
>
> Also, please let me know the process to back-port this feature to the 1.x
> branch. Majorly my question is around if we can release new features under
> that branch or are we restricting new releases on that branch strictly for
> security fixes only. If there is no issue in back-porting some features on
> demand, I will submit a separate PR for 1.x branch which contains relevant
> changes for WorkerHook.
>
>
> On Sun, Jun 18, 2023 at 3:34 PM 6harat <bh...@gmail.com>
> wrote:
>
>> Hey,
>>
>> I submitted a PR for review yesterday and am looking for some help from
>> existing contributors regarding the below:
>>
>> 1. new JIRA ticket for the feature (and if someone can also approve my
>> JIRA account creation request if they are one of the approvers)
>> 2. trigger the github workflow: https://github.com/apache/storm/pull/3546
>> (I already ran the test locally on my machine)
>> 3. provide PR review comments
>>
>> (attached the related mail from users mailing list)
>>
>> Regards
>> 6harat
>>
>
>
> --
> 6harat
> solr enthusiast
> [not affiliated to core dev team]
>
--
Regards
6harat
Re: [PR Review] Support for declaring WorkerHook in Flux topology definitions
Posted by 6harat <bh...@gmail.com>.
Hey,
Just an update on the Apache JIRA account. I was able to get the access
with help from users@infra.apache.org. Requesting existing maintainers to
please add me to the relevant user group for being able to get the JIRA
assigned to myself going forward. (I have create ticket and comment
permission only)
Also, thanks a lot @bipin for approving the github workflow. (It would be
great if I could please get the access as well. I want to trigger it for
other PRs too)
Since the workflow tests have passed and relevant test cases were also
added, could someone please help review the PR.
Also, please let me know the process to back-port this feature to the 1.x
branch. Majorly my question is around if we can release new features under
that branch or are we restricting new releases on that branch strictly for
security fixes only. If there is no issue in back-porting some features on
demand, I will submit a separate PR for 1.x branch which contains relevant
changes for WorkerHook.
On Sun, Jun 18, 2023 at 3:34 PM 6harat <bh...@gmail.com>
wrote:
> Hey,
>
> I submitted a PR for review yesterday and am looking for some help from
> existing contributors regarding the below:
>
> 1. new JIRA ticket for the feature (and if someone can also approve my
> JIRA account creation request if they are one of the approvers)
> 2. trigger the github workflow: https://github.com/apache/storm/pull/3546
> (I already ran the test locally on my machine)
> 3. provide PR review comments
>
> (attached the related mail from users mailing list)
>
> Regards
> 6harat
>
--
6harat
solr enthusiast
[not affiliated to core dev team]