You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 14:19:32 UTC

[GitHub] [airflow] TeddyHartanto commented on a change in pull request #7735: [AIRFLOW-4549] Allow skipped tasks to satisfy wait_for_downstream

TeddyHartanto commented on a change in pull request #7735:
URL: https://github.com/apache/airflow/pull/7735#discussion_r420829036



##########
File path: tests/models/test_taskinstance.py
##########
@@ -855,6 +855,25 @@ def test_check_task_dependencies(self, trigger_rule, successes, skipped,
         self.assertEqual(completed, expect_completed)
         self.assertEqual(ti.state, expect_state)
 
+    @parameterized.expand([

Review comment:
       Ah good point there. I somehow reasoned this wasn't necessary. I couldn't quite remember what the exact reason was. But it could be a misjudgement because now that I take a second look at it, I think we should add it in. Thanks for catching that!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org