You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by br...@apache.org on 2003/01/22 07:50:23 UTC
cvs commit: jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/e maven.xml project.xml
brekke 2003/01/21 22:50:23
Modified: src/test/touchstone-build/src/reactor-build/standard
project.properties
src/test/touchstone-build/src/reactor-build/standard/e
project.xml
Added: src/test/touchstone-build/src/reactor-build/standard/e
maven.xml
Log:
When using the reactor in combination with the jar version override
features of maven there are some problems. These changes are attempts
to reproduce the failures in the reactor-build/standard touchstone
project. There are three things checked for in subproject e's maven.xml:
o shared property is valid
o subproject can override the parents jar version via the <version/> in
it's project.xml
o parents jar version works in the subproject.
To run the tests follow the steps below:
* run the full reactor build
- move to src/test/touchstone-build/src/reactor-build/standard
- run 'maven'
- fails when building subproject e
* run the e subproject build
- move to src/test/touchstone-build/src/reactor-build/standard/e
- run 'maven display'
- The above is a bug, the default goal from the parent's maven.xml is
not being honored so we have to explicity state the goal.
- fails on the first check
Revision Changes Path
1.2 +2 -0 jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/project.properties
Index: project.properties
===================================================================
RCS file: /home/cvs/jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/project.properties,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- project.properties 21 Jan 2003 19:10:32 -0000 1.1
+++ project.properties 22 Jan 2003 06:50:22 -0000 1.2
@@ -1 +1,3 @@
property.to.share = property_to_share
+maven.jar.myjar = 1.2
+maven.jar.junit = 3.8.1
1.2 +9 -0 jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/e/project.xml
Index: project.xml
===================================================================
RCS file: /home/cvs/jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/e/project.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- project.xml 13 Jan 2003 16:43:33 -0000 1.1
+++ project.xml 22 Jan 2003 06:50:22 -0000 1.2
@@ -12,6 +12,15 @@
<version>1.0</version>
</dependency>
+ <dependency>
+ <id>myjar</id>
+ <version>SHOULD-OVERRIDE-PROPERTIES</version>
+ </dependency>
+
+ <dependency>
+ <id>junit</id>
+ </dependency>
+
</dependencies>
</project>
1.1 jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/e/maven.xml
Index: maven.xml
===================================================================
<project
xmlns:j="jelly:core">
<goal name="display">
<echo>Checking property.to.share...</echo>
<j:set var="actual" value="${property.to.share}"/>
<j:set var="expected" value="property_to_share"/>
<j:if test="${actual != expected}">
<fail message="Expected [${expected}] but was [${actual}] : ">
Parent project properties are not being correctly inheirited.
</fail>
</j:if>
<echo>** property.to.share is correct!</echo>
<echo>Checking myjar version...</echo>
<j:set var="actual" value="${pom.getDependency('myjar').getVersion()}"/>
<j:set var="expected" value="SHOULD-OVERRIDE-PROPERTIES"/>
<j:if test="${actual != expected}">
<fail message="Expected [${expected}] but was [${actual}] : ">
Child project jar version override is not functioning.
</fail>
</j:if>
<echo>** myjar version is correct!</echo>
<echo>Checking junit version...</echo>
<j:set var="actual" value="${pom.getDependency('junit').getVersion()}"/>
<j:set var="expected" value="3.8.1"/>
<j:if test="${actual != expected}">
<fail message="Expected [${expected}] but was [${actual}] : ">
Parent project jar version inheiritance is not functioning.
</fail>
</j:if>
<echo>** junit version is correct!</echo>
</goal>
</project>
Re: cvs commit:
jakarta-turbine-maven/src/test/touchstone-build/src/reactor-build/standard/e
maven.xml project.xml
Posted by Jason van Zyl <ja...@zenplex.com>.
On Wed, 2003-01-22 at 01:50, brekke@apache.org wrote:
> brekke 2003/01/21 22:50:23
>
> Modified: src/test/touchstone-build/src/reactor-build/standard
> project.properties
> src/test/touchstone-build/src/reactor-build/standard/e
> project.xml
> Added: src/test/touchstone-build/src/reactor-build/standard/e
> maven.xml
> Log:
> When using the reactor in combination with the jar version override
> features of maven there are some problems. These changes are attempts
> to reproduce the failures in the reactor-build/standard touchstone
> project. There are three things checked for in subproject e's maven.xml:
>
> o shared property is valid
>
> o subproject can override the parents jar version via the <version/> in
> it's project.xml
>
> o parents jar version works in the subproject.
>
> To run the tests follow the steps below:
>
> * run the full reactor build
Jeff, this is awesome! This is exactly the type of thing that is the
most helpful in actually resolving issues surrounding what behaviour
should be expected and how it is broken so that issues can be fixed.
Much appreciated!
--
jvz.
Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society