You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/02 16:45:24 UTC

[GitHub] [accumulo-testing] Manno15 opened a new pull request #175: Fix YieldingScanExecutorPT by adding shaded jar to classpath

Manno15 opened a new pull request #175:
URL: https://github.com/apache/accumulo-testing/pull/175


   Fixes #161. 
   
   The issue with #161 was the class `TimedScanDispatcher.java` could not be found by accumulo. Adding the shaded jar to the classpath (similar to what every other testing script does) fixes that issue and now the test completes successfully. 
   
   
   I did run into one issue. I now have a warning for multiple slf4j bindings that I could not figure out a good solution for (I have tried multiple exclusions in the jar along with various ways to add the shaded jar to the classpath). Below is the snippet for that: 
   
   ```
   SLF4J: Class path contains multiple SLF4J bindings.
   SLF4J: Found binding in [jar:file:/home/jeffrey/git/accumulo-testing/target/accumulo-testing-shaded.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   SLF4J: Found binding in [jar:file:/home/jeffrey/git/fluo-uno/install/accumulo-2.1.0-SNAPSHOT/lib/log4j-slf4j-impl-2.14.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
   SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
   ~                                                                                          
   ```
   
   To note, this does not prevent the test to run but it does break the logging inside fluo-uno. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on pull request #175: Fix YieldingScanExecutorPT by adding shaded jar to classpath

Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #175:
URL: https://github.com/apache/accumulo-testing/pull/175#issuecomment-1079944793


   I also now see: `WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.` when running through the PT. It still passes fine. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on pull request #175: Fix YieldingScanExecutorPT by adding shaded jar to classpath

Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #175:
URL: https://github.com/apache/accumulo-testing/pull/175#issuecomment-1079975167


   Commit https://github.com/apache/accumulo-testing/pull/175/commits/66a30742ecd08a83713eff4b2b515f001a13b0ca added some more exclusions in the pom which does remove some of the warnings but I am not sure of any side effects.
   
   The remaining warning is: 
   
   ```
   [WARNING] datasketches-memory-2.0.0.jar, gson-2.9.0.jar, log4j-api-2.17.2.jar define 1 overlapping classes: 
   [WARNING]   - META-INF.versions.9.module-info
   [WARNING] commons-logging-1.2.jar, htrace-core4-4.1.0-incubating.jar define 2 overlapping resources: 
   [WARNING]   - META-INF/maven/commons-logging/commons-logging/pom.properties
   [WARNING]   - META-INF/maven/commons-logging/commons-logging/pom.xml
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo-testing] Manno15 commented on pull request #175: Fix YieldingScanExecutorPT by adding shaded jar to classpath

Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #175:
URL: https://github.com/apache/accumulo-testing/pull/175#issuecomment-1079943829


   I am seeing quite a bit of jar warnings when building. I do want to tackle those before merging if anyone has suggestions on them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org