You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/01/25 20:15:27 UTC
Review Request 42730: AMBARI-14793. Pre-Check error reports last
upgrade as ABORTED after upgrade then downgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42730/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-14793
https://issues.apache.org/jira/browse/AMBARI-14793
Repository: ambari
Description
-------
*Steps:*
# Install HDP 2.3.4.0 cluster
# Start Rolling/Express Upgrade
# Hit Downgrade at first prompt for manual intervention (during the upgrade process)
# Let the Downgrade finish
# Hit Perform Upgrade
Following pre-check error is reported:
```
Reason: Upgrade attempt (id: 1, request id: 22, from version: 2.3.4.0-3485, to version: 2.4.0.0-128) did not complete task with id 681 since its state is ABORTED instead of COMPLETED. Please ensure that you called:
ambari-server set-current --cluster-name=$CLUSTERNAME --version-display-name=$VERSION_NAME
Further, change the status of host_role_command with id 1 to COMPLETED
Failed on: cl1
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java 4af0896
Diff: https://reviews.apache.org/r/42730/diff/
Testing
-------
Verified on a live cluster after performing an upgrade and downgrade.
Thanks,
Alejandro Fernandez
Re: Review Request 42730: AMBARI-14793. Pre-Check error reports last
upgrade as ABORTED after upgrade then downgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42730/#review116148
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java (lines 104 - 106)
<https://reviews.apache.org/r/42730/#comment177149>
Should have a test.
- Nate Cole
On Jan. 25, 2016, 2:15 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42730/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 2:15 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14793
> https://issues.apache.org/jira/browse/AMBARI-14793
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Steps:*
> # Install HDP 2.3.4.0 cluster
> # Start Rolling/Express Upgrade
> # Hit Downgrade at first prompt for manual intervention (during the upgrade process)
> # Let the Downgrade finish
> # Hit Perform Upgrade
>
> Following pre-check error is reported:
> ```
> Reason: Upgrade attempt (id: 1, request id: 22, from version: 2.3.4.0-3485, to version: 2.4.0.0-128) did not complete task with id 681 since its state is ABORTED instead of COMPLETED. Please ensure that you called:
> ambari-server set-current --cluster-name=$CLUSTERNAME --version-display-name=$VERSION_NAME
> Further, change the status of host_role_command with id 1 to COMPLETED
> Failed on: cl1
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java 4af0896
>
> Diff: https://reviews.apache.org/r/42730/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster after performing an upgrade and downgrade.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 42730: AMBARI-14793. Pre-Check error reports last
upgrade as ABORTED after upgrade then downgrade
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42730/#review116163
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Jan. 25, 2016, 8:41 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42730/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 8:41 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14793
> https://issues.apache.org/jira/browse/AMBARI-14793
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Steps:*
> # Install HDP 2.3.4.0 cluster
> # Start Rolling/Express Upgrade
> # Hit Downgrade at first prompt for manual intervention (during the upgrade process)
> # Let the Downgrade finish
> # Hit Perform Upgrade
>
> Following pre-check error is reported:
> ```
> Reason: Upgrade attempt (id: 1, request id: 22, from version: 2.3.4.0-3485, to version: 2.4.0.0-128) did not complete task with id 681 since its state is ABORTED instead of COMPLETED. Please ensure that you called:
> ambari-server set-current --cluster-name=$CLUSTERNAME --version-display-name=$VERSION_NAME
> Further, change the status of host_role_command with id 1 to COMPLETED
> Failed on: cl1
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java 4af0896
> ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42730/diff/
>
>
> Testing
> -------
>
> Verified on a live cluster after performing an upgrade and downgrade.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 42730: AMBARI-14793. Pre-Check error reports last
upgrade as ABORTED after upgrade then downgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42730/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 8:41 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-14793
https://issues.apache.org/jira/browse/AMBARI-14793
Repository: ambari
Description
-------
*Steps:*
# Install HDP 2.3.4.0 cluster
# Start Rolling/Express Upgrade
# Hit Downgrade at first prompt for manual intervention (during the upgrade process)
# Let the Downgrade finish
# Hit Perform Upgrade
Following pre-check error is reported:
```
Reason: Upgrade attempt (id: 1, request id: 22, from version: 2.3.4.0-3485, to version: 2.4.0.0-128) did not complete task with id 681 since its state is ABORTED instead of COMPLETED. Please ensure that you called:
ambari-server set-current --cluster-name=$CLUSTERNAME --version-display-name=$VERSION_NAME
Further, change the status of host_role_command with id 1 to COMPLETED
Failed on: cl1
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java 4af0896
ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42730/diff/
Testing
-------
Verified on a live cluster after performing an upgrade and downgrade.
Thanks,
Alejandro Fernandez
Re: Review Request 42730: AMBARI-14793. Pre-Check error reports last
upgrade as ABORTED after upgrade then downgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42730/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 8:39 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
Changes
-------
Added unit tests.
Bugs: AMBARI-14793
https://issues.apache.org/jira/browse/AMBARI-14793
Repository: ambari
Description
-------
*Steps:*
# Install HDP 2.3.4.0 cluster
# Start Rolling/Express Upgrade
# Hit Downgrade at first prompt for manual intervention (during the upgrade process)
# Let the Downgrade finish
# Hit Perform Upgrade
Following pre-check error is reported:
```
Reason: Upgrade attempt (id: 1, request id: 22, from version: 2.3.4.0-3485, to version: 2.4.0.0-128) did not complete task with id 681 since its state is ABORTED instead of COMPLETED. Please ensure that you called:
ambari-server set-current --cluster-name=$CLUSTERNAME --version-display-name=$VERSION_NAME
Further, change the status of host_role_command with id 1 to COMPLETED
Failed on: cl1
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java 4af0896
ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42730/diff/
Testing
-------
Verified on a live cluster after performing an upgrade and downgrade.
Thanks,
Alejandro Fernandez