[GitHub] [accumulo-examples] keith-turner commented on a change in pull request #49: Fix #42 Update compactionStrategy example

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #49: Fix #42 Update compactionStrategy example
URL: https://github.com/apache/accumulo-examples/pull/49#discussion_r278947086
 
 

 ##########
 File path: src/main/java/org/apache/accumulo/examples/client/SequentialBatchWriter.java
 ##########
 @@ -52,14 +49,42 @@ public static Value createValue(long rowId) {
     return new Value(value);
   }
 
+  static class Opts extends ClientOpts {
 
 Review comment:
   I think that is because the code has 10,000 as a literal in the for loop.  Could make the for loop later in the code use `opts.num` instead.  Could make the code use `opts.tableName` instead of the literal `"batch"`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services