You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/05/09 14:46:17 UTC
Re: Review Request 58953: Added transitional allocator overloads.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58953/
-----------------------------------------------------------
(Updated May 9, 2017, 4:46 p.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Summary (updated)
-----------------
Added transitional allocator overloads.
Bugs: MESOS-7388
https://issues.apache.org/jira/browse/MESOS-7388
Repository: mesos
Description
-------
This commits adds allocator overloads working with resource providers
instead of agents which currently are assumed to be called with agent
resource providers. This is so that users of the allocator can
transition to the overloads taking resource providers.
In a subsequent commit the allocator overloads directly taking agent
variables will be removed in favor of the ones taking resource
providers; at the same time all methods in the allocator interface
will be made virtual again in order to call specific derived
implementation methods.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7
Diff: https://reviews.apache.org/r/58953/diff/2/
Changes: https://reviews.apache.org/r/58953/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 58953: Added transitional allocator overloads.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58953/#review174313
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On May 9, 2017, 4:46 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58953/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 4:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-7388
> https://issues.apache.org/jira/browse/MESOS-7388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commits adds allocator overloads working with resource providers
> instead of agents which currently are assumed to be called with agent
> resource providers. This is so that users of the allocator can
> transition to the overloads taking resource providers.
>
> In a subsequent commit the allocator overloads directly taking agent
> variables will be removed in favor of the ones taking resource
> providers; at the same time all methods in the allocator interface
> will be made virtual again in order to call specific derived
> implementation methods.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7
>
>
> Diff: https://reviews.apache.org/r/58953/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>