You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "scovich (via GitHub)" <gi...@apache.org> on 2025/08/20 17:32:27 UTC
[PR] [Variant] Rename ValueBuffer as ValueBuilder [arrow-rs]
scovich opened a new pull request, #8187:
URL: https://github.com/apache/arrow-rs/pull/8187
# Which issue does this PR close?
- Closes https://github.com/apache/arrow-rs/issues/8186
# Rationale for this change
The class has always built variant values (metadata being handled separately), so rename it `ValueBuilder` to be more self-documenting.
# What changes are included in this PR?
Class renamed, along with all methods, local variables and documentation that reference it.
# Are these changes tested?
It's a rename. If it compiles it's correct.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Rename ValueBuffer as ValueBuilder [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8187:
URL: https://github.com/apache/arrow-rs/pull/8187#issuecomment-3207625227
I plan to merge this one in as soon as the CI passes, as I think it is likely to accumulate conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Rename ValueBuffer as ValueBuilder [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8187:
URL: https://github.com/apache/arrow-rs/pull/8187#issuecomment-3207647081
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Variant] Rename ValueBuffer as ValueBuilder [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8187:
URL: https://github.com/apache/arrow-rs/pull/8187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org