You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Nicolas Lalevée (JIRA)" <ji...@apache.org> on 2009/01/06 15:18:44 UTC
[jira] Created: (IVYDE-153) Better support the resolve in workspace
feature
Better support the resolve in workspace feature
-----------------------------------------------
Key: IVYDE-153
URL: https://issues.apache.org/jira/browse/IVYDE-153
Project: IvyDE
Issue Type: Improvement
Affects Versions: 2.0.0.beta1
Reporter: Nicolas Lalevée
Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
Drawbacks:
* the resolve can fail if the artifact is not build but the project exist
* we have no control of when a project is included or not
So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVYDE-153) Better support the resolve in
workspace feature
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée resolved IVYDE-153.
-----------------------------------
Resolution: Fixed
Assignee: Nicolas Lalevée
I have finally been able to have a working implementation.
As a first working version, and the complexity of the feature, it needs to be tested in a daily use.
> Better support the resolve in workspace feature
> -----------------------------------------------
>
> Key: IVYDE-153
> URL: https://issues.apache.org/jira/browse/IVYDE-153
> Project: IvyDE
> Issue Type: Improvement
> Affects Versions: 2.0.0.beta1
> Reporter: Nicolas Lalevée
> Assignee: Nicolas Lalevée
> Fix For: 2.0.0.final
>
> Attachments: IVYDE-153-r736034.patch
>
>
> Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
> Drawbacks:
> * the resolve can fail if the artifact is not build but the project exist
> * we have no control of when a project is included or not
> So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-153) Better support the resolve in workspace
feature
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée updated IVYDE-153:
----------------------------------
Fix Version/s: 2.0.0.final
> Better support the resolve in workspace feature
> -----------------------------------------------
>
> Key: IVYDE-153
> URL: https://issues.apache.org/jira/browse/IVYDE-153
> Project: IvyDE
> Issue Type: Improvement
> Affects Versions: 2.0.0.beta1
> Reporter: Nicolas Lalevée
> Fix For: 2.0.0.final
>
>
> Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
> Drawbacks:
> * the resolve can fail if the artifact is not build but the project exist
> * we have no control of when a project is included or not
> So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-153) Better support the resolve in
workspace feature
Posted by "Matt Goldspink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702820#action_12702820 ]
Matt Goldspink commented on IVYDE-153:
--------------------------------------
HI Nicolas,
I'd be happy to test this feature. Our team uses the current resolve in workspace heavily across 15 projects in a workspace so we're heavily dependent on it and wouldn't want to see it break in future versions of the plugin. I'll try it myself this week and see how it works out and see if I can get some of the others in the team to try it too.
> Better support the resolve in workspace feature
> -----------------------------------------------
>
> Key: IVYDE-153
> URL: https://issues.apache.org/jira/browse/IVYDE-153
> Project: IvyDE
> Issue Type: Improvement
> Affects Versions: 2.0.0.beta1
> Reporter: Nicolas Lalevée
> Assignee: Nicolas Lalevée
> Fix For: 2.0.0.final
>
> Attachments: IVYDE-153-r736034.patch
>
>
> Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
> Drawbacks:
> * the resolve can fail if the artifact is not build but the project exist
> * we have no control of when a project is included or not
> So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-153) Better support the resolve in workspace
feature
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée updated IVYDE-153:
----------------------------------
Attachment: IVYDE-153-r736034.patch
Here is a patch that use most of the work done by Eugene Goldfarb (IVYDE-43). To avoid changing user's ivysettings, I made IvyDE use this IvySettings:
{code:java}
private class WorkspaceIvySettings extends IvySettings {
public DependencyResolver getResolver(String resolverName) {
DependencyResolver resolver = super.getResolver(resolverName);
if (resolver == null) {
Message.error("unknown resolver " + resolverName);
return null;
}
ChainResolver chain = new ChainResolver();
chain.setName(javaProject.getElementName() + "-ivyde-workspace-chain-resolver");
chain.setSettings(this);
chain.setReturnFirst(true);
chain.add(new WorkspaceResolver(javaProject, this));
chain.add(resolver);
return chain;
}
}
{code}
But apprently this is making some of my project failing to resolve existing artifacts. In the Ivy console I see logged some:
{code}
==== sandbox-local: tried
/home/nicolasl/dev/tools/ivy/repo-sandbox/com.oracle/ojdbc5/11.1.0.6.0/ivy.xml
{code}
But actually that file does exist... And if I remove the resolve in workspace option in that project, so IvyDE will use normal IvySettings implementation, IvyDE successfully resolve the dependencies, even the ojdbc5.
Some strange side effect is happening here...
> Better support the resolve in workspace feature
> -----------------------------------------------
>
> Key: IVYDE-153
> URL: https://issues.apache.org/jira/browse/IVYDE-153
> Project: IvyDE
> Issue Type: Improvement
> Affects Versions: 2.0.0.beta1
> Reporter: Nicolas Lalevée
> Fix For: 2.0.0.final
>
> Attachments: IVYDE-153-r736034.patch
>
>
> Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
> Drawbacks:
> * the resolve can fail if the artifact is not build but the project exist
> * we have no control of when a project is included or not
> So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-153) Better support the resolve in
workspace feature
Posted by "Matt Goldspink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715873#action_12715873 ]
Matt Goldspink commented on IVYDE-153:
--------------------------------------
Just thought I'd update and say I've been using this for over month now and had no issues. It's been working great for us. Thanks
> Better support the resolve in workspace feature
> -----------------------------------------------
>
> Key: IVYDE-153
> URL: https://issues.apache.org/jira/browse/IVYDE-153
> Project: IvyDE
> Issue Type: Improvement
> Affects Versions: 2.0.0.beta1
> Reporter: Nicolas Lalevée
> Assignee: Nicolas Lalevée
> Fix For: 2.0.0.final
>
> Attachments: IVYDE-153-r736034.patch
>
>
> Today the "resolve in workspace" feature is quite a work around: the resolve process run against the real artifacts in the real repositories, and only after that the resolved artifacts are maybe replaced by the project.
> Drawbacks:
> * the resolve can fail if the artifact is not build but the project exist
> * we have no control of when a project is included or not
> So what we need here is a specific implementation of Ivy's DependencyResolver managed by IvyDE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.