You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/12 07:48:59 UTC

[GitHub] [spark] cloud-fan commented on pull request #34848: [SPARK-37582][SPARK-37583][SQL] CONTAINS, STARTSWITH, ENDSWITH should support binary type

cloud-fan commented on pull request #34848:
URL: https://github.com/apache/spark/pull/34848#issuecomment-1010738703


   Can we follow `LPadExpressionBuilder`? I think the tricky part is type coercion, and my proposal is to follow lpad/rpad:
   1. contains(binary, binary) -> convert to binary contains
   2. for others, convert to string contains and rely on type coercion
   
   This means, for `contains(binary, string)`, we cast the binary to string, which is the same as the old behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org