You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/07 12:48:06 UTC

[GitHub] [superset] michael-s-molina commented on pull request #14987: fix: Aligns top level tabs when native filters are enabled

michael-s-molina commented on pull request #14987:
URL: https://github.com/apache/superset/pull/14987#issuecomment-855895328


   > What do you think about making it look like this?
   > ![image](https://user-images.githubusercontent.com/15073128/121018392-a90e9f00-c79e-11eb-8e29-c141268dc730.png)
   > 
   > I'm not sure if I like that empty space on the left side of the bar with top level tabs
   
   I also think this is the best approach but it seems that we have a requirement from a client asking to nest the filters inside a top-level tab.  @suddjian @junlincc can you check if we can change this requirement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org