[jira] Commented: (TRINIDAD-81) Wrong converting of CSS pseudo classes

["Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513051 ] 

Jeanne Waldman commented on TRINIDAD-81:
----------------------------------------

I could also reproduce this problem. This problem was probably introduced when I recently added code for this use case:

*:active, .AFFoo:read-only {
}

I wanted this to be:

*:active, .AFFoo.p_AFReadOnly {
}
This was issue:
wild-carded skinning pseudo classes incorrectly transformed to CSS-2

I'll take a look at this patch.

FYI - whenever you change skinning code, you should run the simple and the purple skins before your change in compressed and uncompressed mode and save the rendered css file and compare it after your change to make sure it hasn't changed unexpectedly.
Thanks!
Jeanne

> Wrong converting of CSS pseudo classes
> --------------------------------------
>
>                 Key: TRINIDAD-81
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-81
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.0.1-core
>            Reporter: Tomas Havelka
>            Assignee: Jeanne Waldman
>         Attachments: patch4.patch
>
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.