You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Andreas Kohn <an...@gmail.com> on 2013/12/03 11:48:17 UTC
Review Request 15959: Use #getClientId() rather then #getString("client_id")
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15959/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1959
https://issues.apache.org/jira/browse/SHINDIG-1959
Repository: shindig
Description
-------
Improve consistency and use the proper accessor method for getting the client id.
Diffs
-----
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java 1547331
Diff: https://reviews.apache.org/r/15959/diff/
Testing
-------
Review.
Thanks,
Andreas Kohn
Re: Review Request 15959: Use #getClientId() rather then
#getString("client_id")
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15959/#review29942
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Dec. 3, 2013, 10:48 a.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15959/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 10:48 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1959
> https://issues.apache.org/jira/browse/SHINDIG-1959
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Improve consistency and use the proper accessor method for getting the client id.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java 1547331
>
> Diff: https://reviews.apache.org/r/15959/diff/
>
>
> Testing
> -------
>
> Review.
>
>
> Thanks,
>
> Andreas Kohn
>
>
Re: Review Request 15959: Use #getClientId() rather then
#getString("client_id")
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15959/#review29723
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On Dec. 3, 2013, 10:48 a.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15959/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 10:48 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1959
> https://issues.apache.org/jira/browse/SHINDIG-1959
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Improve consistency and use the proper accessor method for getting the client id.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java 1547331
>
> Diff: https://reviews.apache.org/r/15959/diff/
>
>
> Testing
> -------
>
> Review.
>
>
> Thanks,
>
> Andreas Kohn
>
>