You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2026/01/30 04:51:08 UTC

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23921


Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 33 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 5: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2539/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 23:50:38 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 16:46:02 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 7: Verified+1

Unrelated Test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 18:45:10 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#5).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 98 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#3).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 94 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/2236/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Jan 2026 04:53:40 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23921/4/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:

http://gerrit.cloudera.org:8080/#/c/23921/4/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@253
PS4, Line 253: major_version if major_version
Isn't this always true, regardless of what string 'mac_ver' is, unless it's None?  And it cannot be None because platform.mac_ver() tuple doesn't contain nulls even on non-macOS (e.g., on Linux), as described in official docs?

 platform.mac_ver(release='', versioninfo=('', '', ''), machine='')

    Get macOS version information and return it as tuple (release, versioninfo, machine) with versioninfo being a tuple (version, dev_stage, non_release_version).

    Entries which cannot be determined are set to ''. All tuple entries are strings.


http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/build.gradle@54
PS4, Line 54: 'osx'
Just curious: is there any field of osdetector that would naturally be 'osx' on macOS?  Maybe, use it here instead of hard-coding 'osx'?


http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:

http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@70
PS4, Line 70:     String fullVersion = "osx".equals(DETECTOR.getOs()) ?
            :         System.getProperty("os.version")
            :         : (DETECTOR.getRelease() != null ? DETECTOR.getRelease().getVersion() : "0");
Since this is already os-specific, consider moving the code for particular OS under corresponding if/else scope below.



-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 19:30:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 7:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2542/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 16:28:20 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2499/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:41:22 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 6: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2541/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 06:27:27 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2541/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 05:16:37 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 2: Code-Review+1

Overall looks good to me, just a couple questions:
-was there any particular issue that came up, that is fixed by this change?
-does the Kudu Java example work as expected with the new naming? (just to make sure that what we have in the example pom, works)


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 13:30:57 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 4: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/2501/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 22:49:26 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#6).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 101 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/6
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#4).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 94 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#7).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 99 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 2: Code-Review+1

> Overall looks good to me, just a couple questions:
 > -was there any particular issue that came up, that is fixed by this
 > change?
 > -does the Kudu Java example work as expected with the new naming?
 > (just to make sure that what we have in the example pom, works)

+1

How do clients know what JAR to fetch with this change in the name?  Is it necessary to update corresponding examples, etc. along with this update?


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 04 Feb 2026 22:29:30 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23921

to look at the new patch set (#2).

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 33 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23921/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 4: Code-Review+1

Thanks for the details!


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 11:32:27 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 5:

> Uploaded patch set 5.

LINT build failed on Java source code:

Java Gradle check failed


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 00:34:42 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 3:

> -was there any particular issue that came up, that is fixed by this change?
Yes, the issue is specific to Cloudera builds where the kudu-binary jar built in rhel8 was replaced by the one built in rhel9 due to the naming convention. This naming of the jars with the OS version helps with such issues.

> -does the Kudu Java example work as expected with the new naming? (just to make sure that what we have in the example pom, works)
Yes, it should as it downloads the kudu-binary from the maven repo. The pom.xml has to be updated during the next release though to pickup the newly named jars.

> How do clients know what JAR to fetch with this change in the name?  Is it necessary to update corresponding examples, etc. along with this update?
As told above, added todo for this to be taken care of during the next release. And updated other places which will be affected due to the change.


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:56:04 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23921/6/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:

http://gerrit.cloudera.org:8080/#/c/23921/6/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@241
PS6, Line 241:   return resolve_library_paths_macos(lib_search_paths, rpaths)
             : 
> Do we want exactly this path for some reason or it was here for debugging o
Yes, that's not supposed to be there. Removed it. Thanks



-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 16:28:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2237/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Jan 2026 04:53:48 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 2: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/2237/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 05:55:55 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23921/4/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:

http://gerrit.cloudera.org:8080/#/c/23921/4/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@253
PS4, Line 253: major_version if major_version
> Isn't this always true, regardless of what string 'mac_ver' is, unless it's
Good catch - it's redundant indeed. Fixed it.


http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/build.gradle@54
PS4, Line 54: 'osx'
> Just curious: is there any field of osdetector that would naturally be 'osx
Done


http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:

http://gerrit.cloudera.org:8080/#/c/23921/4/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@70
PS4, Line 70:     String fullVersion = "osx".equals(DETECTOR.getOs()) ?
            :         System.getProperty("os.version")
            :         : (DETECTOR.getRelease() != null ? DETECTOR.getRelease().getVersion() : "0");
> Since this is already os-specific, consider moving the code for particular 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 23:39:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2539/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 23:40:06 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 6:

(1 comment)

Overall LGTM as of PS6.  The only question I have is about hard-coded path in relocate_binaries_for_mini_cluster.py: that looks like a temporary provision for debugging/troubleshooting.

http://gerrit.cloudera.org:8080/#/c/23921/6/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py:

http://gerrit.cloudera.org:8080/#/c/23921/6/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@241
PS6, Line 241:   if not rpaths:
             :     rpaths.append("/Users/abhishekchennaka/kudu/thirdparty/installed/uninstrumented/lib")
Do we want exactly this path for some reason or it was here for debugging only and it should be removed?



-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 07:07:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2236/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Jan 2026 04:51:18 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 7: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2542/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 17:06:42 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................

[build] Include OS version in kudu-binary artifact names

Update the naming convention for published Kudu mini-cluster binary
artifacts. Including the specific OS distribution and major version
prevents different build environments (e.g., RHEL 8 vs. RHEL 9) from
overwriting each other in the repository.

Update the logic in KuduBinaryJarExtractor.java and the tests
accordingly. Took the liberty of updating the Kudu version in
the test resources of kudu-test-utils.

Before:
kudu-binary-1.19.0-SNAPSHOT-osx-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-linux-x86_64.jar

After:
kudu-binary-1.19.0-SNAPSHOT-osx15-x86_64.jar
kudu-binary-1.19.0-SNAPSHOT-rhel9-x86_64.jar

Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Reviewed-on: http://gerrit.cloudera.org:8080/23921
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
M examples/java/java-example/pom.xml
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
R java/kudu-test-utils/src/test/resources/fake-kudu-binary/apache-kudu-1.19.0-SNAPSHOT/bin/kudu-tserver
7 files changed, 99 insertions(+), 27 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Abhishek Chennaka: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2499/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:46:08 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Include OS version in kudu-binary artifact names

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23921 )

Change subject: [build] Include OS version in kudu-binary artifact names
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2501/


-- 
To view, visit http://gerrit.cloudera.org:8080/23921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f17971704dfec32a0256383bbc3029743b4674f
Gerrit-Change-Number: 23921
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:56:42 +0000
Gerrit-HasComments: No