You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/03 06:07:07 UTC
[GitHub] [kylin] ChangjiGuo opened a new pull request #1037: delete
/execute_output metadata at the same time when deleting a job
ChangjiGuo opened a new pull request #1037: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1037
delete both /execute and /execute_output metadata when deleting a job.
compress commit #1026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1037: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1037: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1037: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1037: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1037#issuecomment-570478152
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=h1) Report
> Merging [#1037](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6a66518858e4b469359cd5398009a460b2749bd8?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1037 +/- ##
===========================================
- Coverage 25.01% 25% -0.01%
+ Complexity 6180 6179 -1
===========================================
Files 1437 1437
Lines 87639 87653 +14
Branches 12250 12252 +2
===========================================
+ Hits 21919 21920 +1
- Misses 63568 63581 +13
Partials 2152 2152
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1037/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `27.51% <0%> (-1.8%)` | `24 <0> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1037/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `53.4% <0%> (+1.13%)` | `7% <0%> (-1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=footer). Last update [6a66518...dde22b0](https://codecov.io/gh/apache/kylin/pull/1037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1037: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1037: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1037#issuecomment-570478666
## Pull Request Test Coverage Report for [Build 5481](https://coveralls.io/builds/27894042)
* **0** of **14** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.466%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java](https://coveralls.io/builds/27894042/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fdao%2FExecutableDao.java#L381) | 0 | 14 | 0.0%
<!-- | **Total:** | **0** | **14** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/27894042/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 59.09% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/27894042) |
| :-- | --: |
| Change from base [Build 5479](https://coveralls.io/builds/27893739): | -0.003% |
| Covered Lines: | 24075 |
| Relevant Lines: | 87653 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services