You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/18 17:01:54 UTC
[GitHub] [shardingsphere] backdoor20 opened a new pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
backdoor20 opened a new pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115
Fixes #13054.
Changes proposed in this pull request:
Added the test case for
- [ ] ShardingSQLRewriteContextDecorator
- [ ] ShardingParameterRewriterBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946287245
> @backdoor20 Can you fix ci error first?
@strongduanmu can you re-approve the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 edited a comment on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 edited a comment on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-945979938
@strongduanmu / @terrymanu can you help with approving the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946311173
> @strongduanmu can you help me with adding the label **Hacktoberfest** and **Hacktoberfest-accepted**
@backdoor20 Of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946265100
> @strongduanmu / @terrymanu can you help with approving the workflow
@backdoor20 Sorry for late reply, I just approve the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946308694
@strongduanmu can you help me with adding the label **Hacktoberfest** and **Hacktoberfest-accepted**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946312157
@strongduanmu can you review the PR and help with merging the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731442761
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.parameter;
+
+import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import java.util.Collection;
+
+import static org.mockito.Mockito.mock;
+
+public class ShardingParameterRewriterBuilderTest {
Review comment:
@backdoor20 Please add final for ShardingParameterRewriterBuilderTest.
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
Review comment:
@backdoor20 Please add final for ShardingSQLRewriteContextDecoratorTest.
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.parameter;
+
+import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import java.util.Collection;
+
+import static org.mockito.Mockito.mock;
+
+public class ShardingParameterRewriterBuilderTest {
+
+ @Test
+ public void assertGetParameterRewriters() {
+ ShardingSphereSchema shardingSphereSchema = mock(ShardingSphereSchema.class);
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ ShardingParameterRewriterBuilder shardingParameterRewriterBuilder = new ShardingParameterRewriterBuilder(shardingRule, routeContext);
+ Collection<ParameterRewriter> actual = shardingParameterRewriterBuilder.getParameterRewriters(shardingSphereSchema);
+ assert !actual.isEmpty();
Review comment:
@backdoor20 Please replace assert with assertThat.
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ }
+
+ @Test
+ public void assertDecorateForRouteContextWhenNotFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(false);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ }
+
+ @Test
+ public void assertGetOrder() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ int actual = shardingSQLRewriteContextDecorator.getOrder();
+ assert actual == ShardingOrder.ORDER;
Review comment:
@backdoor20 Please follow the [code conduct](https://shardingsphere.apache.org/community/en/contribute/code-conduct/).
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
Review comment:
@backdoor20 Why not make an assertion on sqlRewriteContext?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-945979938
@strongduanmu can you help with the merging of this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-947239424
> @strongduanmu can you review the changes as requested and also re-approve the workflow.
@backdoor20 Ok, I will review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 edited a comment on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 edited a comment on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-945979938
@strongduanmu / @techzhou can you help with approving the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731473483
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.parameter;
+
+import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import java.util.Collection;
+
+import static org.mockito.Mockito.mock;
+
+public class ShardingParameterRewriterBuilderTest {
+
+ @Test
+ public void assertGetParameterRewriters() {
+ ShardingSphereSchema shardingSphereSchema = mock(ShardingSphereSchema.class);
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ ShardingParameterRewriterBuilder shardingParameterRewriterBuilder = new ShardingParameterRewriterBuilder(shardingRule, routeContext);
+ Collection<ParameterRewriter> actual = shardingParameterRewriterBuilder.getParameterRewriters(shardingSphereSchema);
+ assert !actual.isEmpty();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731473938
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
Review comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946346532
@strongduanmu can you trigger the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946684389
@strongduanmu can you review the changes as requested and also re-approve the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-946267370
@backdoor20 Can you fix ci error first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731523211
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public final class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ Assert.assertNull(sqlRewriteContext.getSchema());
+ Assert.assertNull(sqlRewriteContext.getSqlStatementContext());
+ Assert.assertEquals(sqlRewriteContext.getParameters().size(), 0);
Review comment:
@backdoor20 Please use static import and use assertThat instead of assertEquals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731824547
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public final class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ Assert.assertNull(sqlRewriteContext.getSchema());
+ Assert.assertNull(sqlRewriteContext.getSqlStatementContext());
+ Assert.assertEquals(sqlRewriteContext.getParameters().size(), 0);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 commented on a change in pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 commented on a change in pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731473244
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
Review comment:
done
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.parameter;
+
+import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import java.util.Collection;
+
+import static org.mockito.Mockito.mock;
+
+public class ShardingParameterRewriterBuilderTest {
Review comment:
done
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
Review comment:
done
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.rewrite.context;
+
+import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties;
+import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext;
+import org.apache.shardingsphere.infra.route.context.RouteContext;
+import org.apache.shardingsphere.sharding.constant.ShardingOrder;
+import org.apache.shardingsphere.sharding.rule.ShardingRule;
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ShardingSQLRewriteContextDecoratorTest {
+
+ @Test
+ public void assertDecorateForRouteContextWhenIsFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(true);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ }
+
+ @Test
+ public void assertDecorateForRouteContextWhenNotFederated() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ ShardingRule shardingRule = mock(ShardingRule.class);
+ ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class);
+ SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class);
+ RouteContext routeContext = mock(RouteContext.class);
+ when(routeContext.isFederated()).thenReturn(false);
+ shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext);
+ }
+
+ @Test
+ public void assertGetOrder() {
+ ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator();
+ int actual = shardingSQLRewriteContextDecorator.getOrder();
+ assert actual == ShardingOrder.ORDER;
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] backdoor20 edited a comment on pull request #13115: Adding the test cases for ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder
Posted by GitBox <gi...@apache.org>.
backdoor20 edited a comment on pull request #13115:
URL: https://github.com/apache/shardingsphere/pull/13115#issuecomment-945979938
@strongduanmu can you help with approving the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org