You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 20:31:11 UTC

[GitHub] [flink] aljoscha commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

aljoscha commented on pull request #12132:
URL: https://github.com/apache/flink/pull/12132#issuecomment-629467498


   I think we went a bit in the wrong direction with the upgrade test. We don't need one for the whole operator, just for the `BucketStateSerializer`. I turned the `BucketStateSerializerTest` into an upgrade test in my branch: https://github.com/aljoscha/flink/commits/pr-12132-file-sink. You just need to take this, and fix the issues that came up with your changes. Then this test will verify that your now code can still load the previously created snapshots.
   
   I noticed that in your version of `BucketStateSerializerTest` you copied all the V1 serializer code, with this change that is not necessary anymore.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org