You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/05/18 22:18:47 UTC
[jira] [Created] (LUCENE-3117) yank SegmentReader.norm out of
SegmentReader.java
yank SegmentReader.norm out of SegmentReader.java
-------------------------------------------------
Key: LUCENE-3117
URL: https://issues.apache.org/jira/browse/LUCENE-3117
Project: Lucene - Java
Issue Type: Task
Reporter: Robert Muir
While working on flex scoring branch and LUCENE-3012, I noticed it was difficult to navigate
the norms handling in SegmentReader's code.
I think we should yank this inner class out into a separate file as a start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3117) yank SegmentReader.norm out of
SegmentReader.java
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-3117.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.2
Assignee: Robert Muir
Committed revision 1125376, 1125390
hopefully we can take some more steps here soon, to make SR's norms handling less scary.
> yank SegmentReader.norm out of SegmentReader.java
> -------------------------------------------------
>
> Key: LUCENE-3117
> URL: https://issues.apache.org/jira/browse/LUCENE-3117
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3117.patch, LUCENE-3117.patch
>
>
> While working on flex scoring branch and LUCENE-3012, I noticed it was difficult to navigate
> the norms handling in SegmentReader's code.
> I think we should yank this inner class out into a separate file as a start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3117) yank SegmentReader.norm out of
SegmentReader.java
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3117:
--------------------------------
Attachment: LUCENE-3117.patch
oops the last patch had an outdated hack (for calling the silly SR.cloneBytes)
> yank SegmentReader.norm out of SegmentReader.java
> -------------------------------------------------
>
> Key: LUCENE-3117
> URL: https://issues.apache.org/jira/browse/LUCENE-3117
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-3117.patch, LUCENE-3117.patch
>
>
> While working on flex scoring branch and LUCENE-3012, I noticed it was difficult to navigate
> the norms handling in SegmentReader's code.
> I think we should yank this inner class out into a separate file as a start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3117) yank SegmentReader.norm out of
SegmentReader.java
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3117:
--------------------------------
Attachment: LUCENE-3117.patch
> yank SegmentReader.norm out of SegmentReader.java
> -------------------------------------------------
>
> Key: LUCENE-3117
> URL: https://issues.apache.org/jira/browse/LUCENE-3117
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-3117.patch
>
>
> While working on flex scoring branch and LUCENE-3012, I noticed it was difficult to navigate
> the norms handling in SegmentReader's code.
> I think we should yank this inner class out into a separate file as a start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3117) yank SegmentReader.norm out of
SegmentReader.java
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035642#comment-13035642 ]
Michael McCandless commented on LUCENE-3117:
--------------------------------------------
+1, this code is scary, and pulling it out is a great baby step.
> yank SegmentReader.norm out of SegmentReader.java
> -------------------------------------------------
>
> Key: LUCENE-3117
> URL: https://issues.apache.org/jira/browse/LUCENE-3117
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-3117.patch
>
>
> While working on flex scoring branch and LUCENE-3012, I noticed it was difficult to navigate
> the norms handling in SegmentReader's code.
> I think we should yank this inner class out into a separate file as a start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org