You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bharatl <gi...@git.apache.org> on 2015/11/09 07:50:08 UTC
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
GitHub user bharatl opened a pull request:
https://github.com/apache/spark/pull/9560
[SPARK-11581][Docs] Example mllib code in documentation incorrectly computes MSE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bharatl/spark SPARK-11581
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9560
----
commit 1582ce8ba02cf5e905931ccf01a7acc70275a3d4
Author: Bharat Lal <bh...@gmail.com>
Date: 2015-11-09T06:48:29Z
corrected computation of MSE in mllib docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9560#issuecomment-154973943
**[Test build #2019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2019/consoleFull)** for PR 9560 at commit [`1582ce8`](https://github.com/apache/spark/commit/1582ce8ba02cf5e905931ccf01a7acc70275a3d4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:\n * `case class DropAnyNull(child: Expression) extends UnaryExpression with ExpectsInputTypes `\n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9560#issuecomment-155166778
LGTM, merging with master, branch-1.6, branch-1.5, and branch-1.4
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9560#issuecomment-154967662
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11581][Docs] Example mllib code in docu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9560#issuecomment-154968913
**[Test build #2019 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2019/consoleFull)** for PR 9560 at commit [`1582ce8`](https://github.com/apache/spark/commit/1582ce8ba02cf5e905931ccf01a7acc70275a3d4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org