[jira] [Commented] (IGNITE-10172) Enabling cache statistics on a large cluster with a large number of caches can affect performance

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689535#comment-16689535 ] 

ASF GitHub Bot commented on IGNITE-10172:
-----------------------------------------

GitHub user alex-plekhanov opened a pull request:

    https://github.com/apache/ignite/pull/5416

    IGNITE-10172 System flag introduced to disable discovery cache metrics updates

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alex-plekhanov/ignite ignite-10172

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5416
    
----
commit 9fc84a2cb82286c2d73c4d905aab5e82a0d9604f
Author: Aleksey Plekhanov <pl...@...>
Date:   2018-11-08T12:25:25Z

    IGNITE-10172 System property to disable discovery cache metrics update

commit ea9a3992eade1f24c53ce541a22a7090c0519475
Author: Aleksey Plekhanov <pl...@...>
Date:   2018-11-16T15:04:29Z

    IGNITE-10172 Unit test

----


> Enabling cache statistics on a large cluster with a large number of caches can affect performance
> -------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10172
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10172
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.6
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>             Fix For: 2.8
>
>
> In current implementation cache metrics are collected on each node and sent across whole cluster with discovery message ({{TcpDiscoveryMetricsUpdateMessage}}) with configured frequency ({{MetricsUpdateFrequency}}, 2 seconds by default).
> If there are a lot of caches and a lot of nodes in the cluster, metrics update message (which contain metrics for each cache on each node) can reach a critical size.
> Also frequently collecting all cache metrics have a negative performance impact.
> The only way now to disable cache metrics collecting and sending with discovery metrics update message is to disable statistics for each cache. But this also makes impossible to request some of cache metrics locally (for the current node only). Requesting a limited set of cache metrics on the current node doesn't have such performance impact as the frequent collecting of all cache metrics, but sometimes it's enough for diagnostic purposes.
> To solve this introduce new system property which will disable cache metrics sending with {{TcpDiscoveryMetricsUpdateMessage}} even if {{statisticsEnabled}} flag is true.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)