You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/03/18 13:31:32 UTC

[GitHub] [daffodil] stevedlawrence commented on pull request #514: Update jansi to 2.3.2

stevedlawrence commented on pull request #514:
URL: https://github.com/apache/daffodil/pull/514#issuecomment-801928222


   Actually, I'm wondering if we can just remove this jansi dependency entirely? I don't see any referenes to jansi in the code. The CLI seems to work fine with this dependency removed. All the CLI integration tests pass for me. And I don't think we use ANSI escape codes anywhere, which I think is the purpose of jansi.
   
   Looks like this was added in commit 9c9b1a5dbd00ae488439a167b3c19c9acb1269ce which mentions issus with windows and eclipse? Maybe this solves some issue by just being on the classpath? From the readme of jansi, that doesn't sound like it's the case. Sounds like you have to use some Jansi function for this library to have an affect.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org