You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2011/11/26 18:40:16 UTC

svn commit: r1206508 - in /ofbiz/branches/release11.04: ./ applications/accounting/servicedef/secas_olap.xml

Author: jleroux
Date: Sat Nov 26 17:40:16 2011
New Revision: 1206508

URL: http://svn.apache.org/viewvc?rev=1206508&view=rev
Log:
"Applied fix from trunk for revision: 1206507" 
------------------------------------------------------------------------
r1206507 | jleroux | 2011-11-26 18:38:56 +0100 (sam., 26 nov. 2011) | 7 lines

A patch from Paul Foxworthy "loadSalesInvoiceFact should be post-run" https://issues.apache.org/jira/browse/OFBIZ-4582

See thread at http://ofbiz.135035.n4.nabble.com/Should-loadSalesInvoiceFact-be-run-on-return-instead-of-commit-td3896289.html

The loadSalesInvoiceFact service in applications/accounting/servicedef/secas_olap.xml is set to run asynchronously on (that is, before) a commit. The result is that the service may attempt to read an order that has not yet been committed.

In the patch, the timing has been changed to global-commit-post-run to ensure the order has been committed.
------------------------------------------------------------------------


Modified:
    ofbiz/branches/release11.04/   (props changed)
    ofbiz/branches/release11.04/applications/accounting/servicedef/secas_olap.xml

Propchange: ofbiz/branches/release11.04/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sat Nov 26 17:40:16 2011
@@ -2,4 +2,4 @@
 /ofbiz/branches/dojo1.4:951708-952957
 /ofbiz/branches/jquery:952958-1044489
 /ofbiz/branches/multitenant20100310:921280-927264
-/ofbiz/trunk:1100197,1100880,1104423,1131144,1131396,1132496,1132749,1133353,1134990,1135199,1135686,1135929,1137201,1137433,1137435,1138463,1138485,1139346,1139385,1139504,1139521,1140358,1140362,1140375,1140469,1144537,1144791,1153073,1153768,1158124,1158126,1158608,1159080,1163036,1163093,1163533,1165130,1166591,1167116,1167314,1167480,1167501,1167510,1167517,1167606,1172213,1172243,1174964,1175130,1175135,1175143,1177128,1178175,1178199,1180398,1181878,1182259,1182310,1182731,1182858,1183651,1184906,1184996,1184999,1185179,1187515,1187528,1187933,1187944,1188042,1188564,1189592,1189601,1190134,1194958,1196778,1199276,1199450,1200207,1201110,1201125,1201941,1203350,1203776
+/ofbiz/trunk:1100197,1100880,1104423,1131144,1131396,1132496,1132749,1133353,1134990,1135199,1135686,1135929,1137201,1137433,1137435,1138463,1138485,1139346,1139385,1139504,1139521,1140358,1140362,1140375,1140469,1144537,1144791,1153073,1153768,1158124,1158126,1158608,1159080,1163036,1163093,1163533,1165130,1166591,1167116,1167314,1167480,1167501,1167510,1167517,1167606,1172213,1172243,1174964,1175130,1175135,1175143,1177128,1178175,1178199,1180398,1181878,1182259,1182310,1182731,1182858,1183651,1184906,1184996,1184999,1185179,1187515,1187528,1187933,1187944,1188042,1188564,1189592,1189601,1190134,1194958,1196778,1199276,1199450,1200207,1201110,1201125,1201941,1203350,1203776,1206507

Modified: ofbiz/branches/release11.04/applications/accounting/servicedef/secas_olap.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release11.04/applications/accounting/servicedef/secas_olap.xml?rev=1206508&r1=1206507&r2=1206508&view=diff
==============================================================================
--- ofbiz/branches/release11.04/applications/accounting/servicedef/secas_olap.xml (original)
+++ ofbiz/branches/release11.04/applications/accounting/servicedef/secas_olap.xml Sat Nov 26 17:40:16 2011
@@ -23,7 +23,7 @@ under the License.
 
     <!-- fact entities -->
     <!-- Load data into the SalesInvoiceItemFact olap entity when a sales invoice is set to ready -->
-    <eca service="setInvoiceStatus" event="commit">
+    <eca service="setInvoiceStatus" event="global-commit-post-run">
         <condition field-name="statusId" operator="equals" value="INVOICE_READY"/>
         <condition-field field-name="statusId" operator="not-equals" to-field-name="oldStatusId"/>
         <action service="loadSalesInvoiceFact" mode="async" run-as-user="system"/>