You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/15 15:14:59 UTC
[jira] [Commented] (CAY-2170) MergeToken sorting is highly unstable
now
[ https://issues.apache.org/jira/browse/CAY-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751609#comment-15751609 ]
ASF GitHub Bot commented on CAY-2170:
-------------------------------------
GitHub user stariy95 opened a pull request:
https://github.com/apache/cayenne/pull/159
CAY-2170 MergeToken sorting is highly unstable
- introduced explicit sorting weight to MergerToken
- all sorting now based exclusively on this weight
- removed TokenComparator as MergerTokens are now directly comparable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stariy95/cayenne CAY-2170_
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cayenne/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit 67e951ba5982229b55e8da1640e8b0bad5d795aa
Author: Nikita Timofeev <st...@gmail.com>
Date: 2016-12-15T13:44:49Z
CAY-2170 MergeToken sorting is highly unstable now
- introduced explicit sorting weight to MergerToken
- all sorting now based exclusively on this weight
- some minor refactoring
commit a026d83049b9b6918f017a6acea1ee4d2a557b16
Author: Nikita Timofeev <st...@gmail.com>
Date: 2016-12-15T15:13:08Z
Remove TokenComparator as MergerTokens are now directly comparable
----
> MergeToken sorting is highly unstable now
> -----------------------------------------
>
> Key: CAY-2170
> URL: https://issues.apache.org/jira/browse/CAY-2170
> Project: Cayenne
> Issue Type: Sub-task
> Components: Modeler, Non-GUI Tools
> Reporter: Nikita Timofeev
> Assignee: Nikita Timofeev
>
> MergeToken sorting is actually depends on many factors and thus highly unstable even with minor changes.
> Need to fix this probably by introducing some sort of explicit weight in every token.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)