You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/13 22:17:30 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #1776: Remove extra application of EXTRAFLAGS and KDEFINE and the arch-level

v01d opened a new pull request #1776:
URL: https://github.com/apache/incubator-nuttx/pull/1776


   ## Summary
   
   EXTRAFLAGS is already applied to *FLAGS in board's Make.defs (and
   it applies to whole build, not just arch-code). EXTRAFLAGS is passed
   around each make call to the complete build.
   
   KDEFINE is already added to EXTRAFLAGS in main Makefile so no need
   to add it again in arch-level Makefile
   
   ## Impact
   
   Build
   
   ## Testing
   
   Built locally, verified KDEFINEs appear where expected and only once. Also,
   tested by doing make EXTRAFLAGS=<flag> and verify it also appears everywhere
   and only once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1776: Remove extra application of EXTRAFLAGS and KDEFINE at the arch-level

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1776:
URL: https://github.com/apache/incubator-nuttx/pull/1776#issuecomment-691974961


   @v01d - Thank you for the detailed PR info, the context is so helpful. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt merged pull request #1776: Remove extra application of EXTRAFLAGS and KDEFINE at the arch-level

Posted by GitBox <gi...@apache.org>.
yamt merged pull request #1776:
URL: https://github.com/apache/incubator-nuttx/pull/1776


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org