You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/20 06:27:43 UTC
Review Request 70018: Avoided waiting for 180s when test
`NvidiaDockerImage` fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70018/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
Repository: mesos
Description
-------
Originally if test `NvidiaDockerImage` fails to wait for the expected
`TASK_FINISHED` and `TASK_FAILED` states, it would wait for 180s so the
`AWAIT_READY` would time out. This patch fixes this issue by matching
any terminal task status updates.
Diffs
-----
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 040453e8d9538cb0f534a8188a89c864d5ddef3f
Diff: https://reviews.apache.org/r/70018/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70018: Avoided waiting for 180s when test
`NvidiaDockerImage` fails.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70018/#review213173
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 20, 2019, 6:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70018/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2019, 6:27 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Originally if test `NvidiaDockerImage` fails to wait for the expected
> `TASK_FINISHED` and `TASK_FAILED` states, it would wait for 180s so the
> `AWAIT_READY` would time out. This patch fixes this issue by matching
> any terminal task status updates.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 040453e8d9538cb0f534a8188a89c864d5ddef3f
>
>
> Diff: https://reviews.apache.org/r/70018/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70018: Avoided waiting for 180s when test
`NvidiaDockerImage` fails.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70018/#review212951
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70016, 70017, 70018]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 20, 2019, 7:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70018/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2019, 7:27 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Originally if test `NvidiaDockerImage` fails to wait for the expected
> `TASK_FINISHED` and `TASK_FAILED` states, it would wait for 180s so the
> `AWAIT_READY` would time out. This patch fixes this issue by matching
> any terminal task status updates.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 040453e8d9538cb0f534a8188a89c864d5ddef3f
>
>
> Diff: https://reviews.apache.org/r/70018/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70018: Avoided waiting for 180s when test
`NvidiaDockerImage` fails.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70018/#review212948
-----------------------------------------------------------
PASS: Mesos patch 70018 was successfully built and tested.
Reviews applied: `['70016', '70017', '70018']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2904/mesos-review-70018
- Mesos Reviewbot Windows
On Feb. 20, 2019, 6:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70018/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2019, 6:27 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Originally if test `NvidiaDockerImage` fails to wait for the expected
> `TASK_FINISHED` and `TASK_FAILED` states, it would wait for 180s so the
> `AWAIT_READY` would time out. This patch fixes this issue by matching
> any terminal task status updates.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 040453e8d9538cb0f534a8188a89c864d5ddef3f
>
>
> Diff: https://reviews.apache.org/r/70018/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>