You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/13 00:47:27 UTC

[GitHub] [superset] lyndsiWilliams commented on pull request #22610: feat: Enable new dataset creation flow

lyndsiWilliams commented on PR #22610:
URL: https://github.com/apache/superset/pull/22610#issuecomment-1381165299

   > One (last, I swear) thing I just noticed is that in the previous modal, saving a dataset would redirect you to `/chart/add` with a `?dataset=table_name` query string, which would autoselect the just-created dataset and also show a toast on the Add Chart page. If this behavior is easy to reproduce it should probably be maintained, but feel free to do it in a separate PR. Database autoselect now works great and everything else LGTM!
   
   Easy fix, thanks for that catch! Fixed in [`this commit`](https://github.com/apache/superset/pull/22610/commits/5941d037e9c2a7958a3d1d6f82827ab4ce3c9143).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org