You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Juan Ramos (Jira)" <ji...@apache.org> on 2020/02/27 12:46:00 UTC

[jira] [Created] (GEODE-7820) Avoid Unnecessary toArray Invocations

Juan Ramos created GEODE-7820:
---------------------------------

             Summary: Avoid Unnecessary toArray Invocations
                 Key: GEODE-7820
                 URL: https://issues.apache.org/jira/browse/GEODE-7820
             Project: Geode
          Issue Type: Bug
          Components: membership
            Reporter: Juan Ramos
         Attachments: setRecipients.png

The {{DistributionMessage}} class receives the recipients as a {{Collection}} object (which is always a {{Set}} after inspecting the calls) but it internally transforms the collection into an array {{[]}}, this transformation appears to be useless as we end up converting the array {{[]}} into a {{List}} across several parts of the code afterwards when we need to do something with it.
Using one of our internal testing scenarios and a java profiler we detected that, under the current develop {{branch}}, we spend ~8 seconds more than when using Geode 1.10 just by executing this {{toArray}} transformation (screenshot attached), which can be completely avoided.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)