[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #402: feat(go/adbc/driver/flightsql): bump max incoming message size

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #402:
URL: https://github.com/apache/arrow-adbc/pull/402#discussion_r1088215952


##########
docs/source/driver/go/flight_sql.rst:
##########
@@ -130,11 +130,16 @@ These options map 1:1 with the options in FlightClientOptions:
     Override the root certificates used to validate the server's TLS
     certificate.
 
-``arrow.flight.sql.client_option.generic_int_option.<OPTION_NAME>``
-    Option prefixes used to specify generic transport-layer options.
-
-``arrow.flight.sql.client_option.generic_string_option.<OPTION_NAME>``
-    Option prefixes used to specify generic transport-layer options.
+``arrow.flight.sql.client_option.with_block``
+    Whether connections should wait until connections are established,
+    or connect lazily when used.  The latter is gRPC's default
+    behavior, but the driver defaults to eager connection to surface
+    errors earlier.  Value should be ``true`` or ``false``.
+
+``arrow.flight.sql.client_option.with_max_msg_size``
+    The maximum message size to accept from the server.  The driver
+    defaults to 16 MiB since Flight services tend to return larger
+    reponse payloads.  Should be a positive integer number of bytes.

Review Comment:
   we have a slight disconnect.... the docs say `arrow.flight.sql.....` but the actual flags we're using are `adbc.flight.sql....` which should it actually be? we should update the docs/code/tests so everything is in sync with what is expected here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org