You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "TanuSharma2511 (via GitHub)" <gi...@apache.org> on 2025/03/21 07:11:31 UTC
[PR] Removing snappy adding crc32c [beam]
TanuSharma2511 opened a new pull request, #34374:
URL: https://github.com/apache/beam/pull/34374
Replaces snappy with google-crc32c to fix the issue #34226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding google-crc32c [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #34374:
URL: https://github.com/apache/beam/pull/34374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removing snappy adding crc32c [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34374:
URL: https://github.com/apache/beam/pull/34374#issuecomment-2742686268
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removing snappy adding crc32c [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #34374:
URL: https://github.com/apache/beam/pull/34374#discussion_r2007659800
##########
sdks/python/apache_beam/io/tfrecordio.py:
##########
@@ -41,23 +41,20 @@
def _default_crc32c_fn(value):
- """Calculates crc32c of a bytes object using either snappy or crcmod."""
+ """Calculates crc32c of a bytes object using either google-crc32c or crcmod."""
if not _default_crc32c_fn.fn:
try:
- import snappy # pylint: disable=import-error
- # Support multiple versions of python-snappy:
- # https://github.com/andrix/python-snappy/pull/53
- if getattr(snappy, '_crc32c', None):
- _default_crc32c_fn.fn = snappy._crc32c # pylint: disable=protected-access
- elif getattr(snappy, '_snappy', None):
- _default_crc32c_fn.fn = snappy._snappy._crc32c # pylint: disable=protected-access
- except ImportError:
+ import google_crc32c # pylint: disable=import-error
Review Comment:
we cannot just remove snappy. To keep back compatible, we should keep this and add the check for google_crc32c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding google-crc32c [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34374:
URL: https://github.com/apache/beam/pull/34374#issuecomment-2745133457
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding google-crc32c [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #34374:
URL: https://github.com/apache/beam/pull/34374#issuecomment-2749220869
R: @liferoad @tvalentyn
adding you since you have more context here - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding google-crc32c [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34374:
URL: https://github.com/apache/beam/pull/34374#issuecomment-2749223546
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org