You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/06/22 16:08:11 UTC
[GitHub] [netbeans] entlicher opened a new pull request #3013: Provide an error message when POM status is invalid.
entlicher opened a new pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013
If there is a Maven project with wrong pom.xml, just a generic error dialog is displayed: https://issues.apache.org/jira/browse/NETBEANS-5803
This PR adds the specific error message to the dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#issuecomment-946618494
What's the current status of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#discussion_r666694813
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
if (s == status) {
Review comment:
`statusMessage` does not behave as a property; can be only updated during a state change ... which can be reasonable. Pls. document the behaviour, `status` name looks like property updatable even during a single state.
##########
File path: java/maven/nbproject/project.xml
##########
@@ -369,7 +369,7 @@
<compile-dependency/>
<run-dependency>
<release-version>1</release-version>
- <specification-version>1.4</specification-version>
+ <specification-version>1.45</specification-version>
Review comment:
No - see [change in XAM in this PR](https://github.com/apache/netbeans/pull/3013/files#diff-d4cbe9616caee5c9e8a0b7766f54bf932349c61e0bcc223082bbebfa3c117ae2R24)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#issuecomment-1014631473
@entlicher has conflicts and unresolved conversations, so removing from all milestones and marking as stale. Please update or close as appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#discussion_r656487013
##########
File path: java/maven/nbproject/project.xml
##########
@@ -369,7 +369,7 @@
<compile-dependency/>
<run-dependency>
<release-version>1</release-version>
- <specification-version>1.4</specification-version>
+ <specification-version>1.45</specification-version>
Review comment:
Looks like a large jump, should this be `1.5`?
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
if (s == status) {
return;
}
State old = status;
status = s;
+ statusMessage = message;
PropertyChangeEvent event =
Review comment:
`statusMessage`is a different property, so I would expect both `PropertyChangeEvents` to be fired.
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
Review comment:
The `if` construct in line 193 (new) looks wrong - the state could stay the same, but the message could change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#issuecomment-885635295
pending conversation moving to 12.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3013: Provide an error message when POM status is invalid.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#discussion_r667046054
##########
File path: java/maven/nbproject/project.xml
##########
@@ -369,7 +369,7 @@
<compile-dependency/>
<run-dependency>
<release-version>1</release-version>
- <specification-version>1.4</specification-version>
+ <specification-version>1.45</specification-version>
Review comment:
Thank you - makes sense now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists