You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/11/08 00:48:20 UTC
[GitHub] cordova-ios pull request #274: CB-12118 - Cordova run ios does not automatic...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/274
CB-12118 - Cordova run ios does not automatically deploy to device
### Platforms affected
self
### What does this PR do?
When you have a device connected, "cordova run ios" does not build for device, only for emulator.
The logic to detect that a device is connected is only in the run phase, not the build phase, thus it was failing.
### What testing has been done on this change?
Manual add of platform, then "cordova platform run ios" with device connected and disconnected, and adding "--emulator" and "--device" flag combinations.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12118
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit d94f35ebf6b542ba3cf2d5e0f4c54b3dd5716dbd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-11-08T00:41:15Z
CB-12118 - Cordova run ios does not automatically deploy to device
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #274: CB-12118 - Cordova run ios does not automatic...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #274: CB-12118 - Cordova run ios does not automatically de...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/274
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/274?src=pr) is 60.00% (diff: 0.00%)
> Merging [#274](https://codecov.io/gh/apache/cordova-ios/pull/274?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will decrease coverage by **0.31%**
```diff
@@ master #274 diff @@
==========================================
Files 12 12
Lines 1318 1325 +7
Methods 200 202 +2
Messages 0 0
Branches 223 224 +1
==========================================
Hits 795 795
- Misses 523 530 +7
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [fa72583...d94f35e](https://codecov.io/gh/apache/cordova-ios/compare/fa72583eaa1cb91c6473e179ed6b9df392f73c50...d94f35ebf6b542ba3cf2d5e0f4c54b3dd5716dbd?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org