You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/04/21 18:28:46 UTC

[GitHub] [fineract-cn-mobile] EGOR-IND opened a new pull request #186: Add edit check to the edit activities

EGOR-IND opened a new pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186


   Fixes #Issue_number
   
   Please Add Screenshots If any UI changes.
   
   Please Add Summary of what changes you have made and if possible provide links.(Optional)
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
   
   - [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
   
   - [x] If you have multiple commits please combine them into one commit by squashing them.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #186: Add edit check to the edit activities

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618228950



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
     <string name="please_wait">Please wait &#8230;</string>
     <string name="logging_in">Logging in…</string>
 
+    <!--Edit Check Messages-->
+    <string name="customer_edit_check_msg">Information not edited for the customer %1$s</string>
+    <string name="group_edit_check_msg">Information not edited for the group %1$s</string>
+    <string name="payroll_edit_check_msg">Information not edited for the payroll with customer identifier %1$s</string>
+    <string name="identification_edit_check_msg">Information not edited for the identification type %1$s</string>
+

Review comment:
       I dont find toast bad but as you suggested it is better to confirm and save change if user edited or else it should show something like "You didn't change any data. Are you sure you want to exit?". It be probably better that this toast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #186: Add edit check to the edit activities

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618098525



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
     <string name="please_wait">Please wait &#8230;</string>
     <string name="logging_in">Logging in…</string>
 
+    <!--Edit Check Messages-->
+    <string name="customer_edit_check_msg">Information not edited for the customer %1$s</string>
+    <string name="group_edit_check_msg">Information not edited for the group %1$s</string>
+    <string name="payroll_edit_check_msg">Information not edited for the payroll with customer identifier %1$s</string>
+    <string name="identification_edit_check_msg">Information not edited for the identification type %1$s</string>
+

Review comment:
       @EGOR-IND Its good to check if user has changed so that unnecessary operations are not performed. But it would suggest that its ok if you dont notify user that he/she has not changed info as user would know it. Instead if user changed info **save and exit** and if not **do quiet exit**. What do you say are toasts mandatory?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND commented on a change in pull request #186: Add edit check to the edit activities

Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618128620



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
     <string name="please_wait">Please wait &#8230;</string>
     <string name="logging_in">Logging in…</string>
 
+    <!--Edit Check Messages-->
+    <string name="customer_edit_check_msg">Information not edited for the customer %1$s</string>
+    <string name="group_edit_check_msg">Information not edited for the group %1$s</string>
+    <string name="payroll_edit_check_msg">Information not edited for the payroll with customer identifier %1$s</string>
+    <string name="identification_edit_check_msg">Information not edited for the identification type %1$s</string>
+

Review comment:
       See I think toasts are good, I don't see any harm in that, it's just a simple indicatiin that they haven't change anything, I can add a dialog if you find snackbar inconvenient, the dialog can have an exit and cancel button, user can exit if they don't want any changes or they can simply press cancel and get back to the edit section. What do you think? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org