[jira] [Updated] (RATIS-394) Remove the assertion while setting the exception in TransactionContextImpl

["Shashikant Banerjee (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/RATIS-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shashikant Banerjee updated RATIS-394:
--------------------------------------
    Description: 
In the below code in TransactionContextImpl,
{code:java}
@Override
public TransactionContext setException(Exception ioe) {
  assert exception != null;
  this.exception = ioe;
  return this;
}
{code}
While setting the exception it asserts the exception maintained in the object is not null or not. While setting the exception first time, it will be null always and hence asserts. We should relax the check here.

  was:
In the below code in TransactionContaextImpl,
{code:java}
@Override
public TransactionContext setException(Exception ioe) {
  assert exception != null;
  this.exception = ioe;
  return this;
}
{code}
While setting the exception it asserts the exception maintained in the object is not null or not. While setting the exception first time, it will be null always and hence asserts. We should relax the check here.


> Remove the assertion while setting the exception in TransactionContextImpl
> --------------------------------------------------------------------------
>
>                 Key: RATIS-394
>                 URL: https://issues.apache.org/jira/browse/RATIS-394
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.3.0
>
>
> In the below code in TransactionContextImpl,
> {code:java}
> @Override
> public TransactionContext setException(Exception ioe) {
>   assert exception != null;
>   this.exception = ioe;
>   return this;
> }
> {code}
> While setting the exception it asserts the exception maintained in the object is not null or not. While setting the exception first time, it will be null always and hence asserts. We should relax the check here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)